Dedicated token store#279
Conversation
🦋 Changeset detectedLatest commit: f9ef5e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
73287f9 to
31bcbe9
Compare
|
View your CI Pipeline Execution ↗ for commit f9ef5e3.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 49.33% 50.55% +1.22%
==========================================
Files 29 29
Lines 1571 1626 +55
Branches 173 196 +23
==========================================
+ Hits 775 822 +47
- Misses 796 804 +8 🚀 New features to boost your workflow:
|
|
Deployed 7737266 to https://ForgeRock.github.io/ping-javascript-sdk/pr-279/7737266c5ee3ddaafb084d2ce3498a9f68648498 branch gh-pages in ForgeRock/ping-javascript-sdk |
23ddfc6 to
13ba7fa
Compare
cerebrl
left a comment
There was a problem hiding this comment.
I think this looks good. Since it mentions it in the Jira ticket, can we also include the scaffolding for an E2E test for the OIDC Client? It can just be a "Hello, World!" type test.
| "test": { | ||
| "inputs": ["default", "^default", "noMarkdown", "^noMarkdown"], | ||
| "dependsOn": ["^test", "^build"], | ||
| "dependsOn": ["^test", "^build", "^build"], |
There was a problem hiding this comment.
Is there a need to duplicate "^build" here?
There was a problem hiding this comment.
no, this is just annoying that nx keeps adding when we generate a package, maybe its fixed as i have not upgraded in awhile.
524cb60 to
810b121
Compare
810b121 to
5d9b3ad
Compare
802cbb3 to
f9ef5e3
Compare
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-4012
https://pingidentity.atlassian.net/browse/SDKS-3797
Description
Creates the oidc client package, and the token-store from the generic storage module.