Skip to content

Dedicated token store#279

Merged
ryanbas21 merged 4 commits into
mainfrom
dedicated-token-store
May 19, 2025
Merged

Dedicated token store#279
ryanbas21 merged 4 commits into
mainfrom
dedicated-token-store

Conversation

@ryanbas21
Copy link
Copy Markdown
Collaborator

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-4012

https://pingidentity.atlassian.net/browse/SDKS-3797

Description

Creates the oidc client package, and the token-store from the generic storage module.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2025

🦋 Changeset detected

Latest commit: f9ef5e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@forgerock/oidc-client Patch
@forgeorck/oidc-app Patch
@forgerock/davinci-client Patch
@forgerock/sdk-types Patch
@forgerock/sdk-utilities Patch
@forgerock/iframe-manager Patch
@forgerock/sdk-logger Patch
@forgerock/sdk-oidc Patch
@forgerock/sdk-request-middleware Patch
@forgerock/storage Patch
@forgerock/oidc-suites Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryanbas21 ryanbas21 force-pushed the dedicated-token-store branch from 73287f9 to 31bcbe9 Compare May 14, 2025 16:16
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 14, 2025

View your CI Pipeline Execution ↗ for commit f9ef5e3.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 29s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-16 21:42:36 UTC

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.55%. Comparing base (54a8029) to head (f9ef5e3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   49.33%   50.55%   +1.22%     
==========================================
  Files          29       29              
  Lines        1571     1626      +55     
  Branches      173      196      +23     
==========================================
+ Hits          775      822      +47     
- Misses        796      804       +8     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2025

Deployed 7737266 to https://ForgeRock.github.io/ping-javascript-sdk/pr-279/7737266c5ee3ddaafb084d2ce3498a9f68648498 branch gh-pages in ForgeRock/ping-javascript-sdk

@ryanbas21 ryanbas21 force-pushed the dedicated-token-store branch 2 times, most recently from 23ddfc6 to 13ba7fa Compare May 14, 2025 16:46
Copy link
Copy Markdown
Collaborator

@cerebrl cerebrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Since it mentions it in the Jira ticket, can we also include the scaffolding for an E2E test for the OIDC Client? It can just be a "Hello, World!" type test.

Comment thread nx.json
"test": {
"inputs": ["default", "^default", "noMarkdown", "^noMarkdown"],
"dependsOn": ["^test", "^build"],
"dependsOn": ["^test", "^build", "^build"],
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need to duplicate "^build" here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is just annoying that nx keeps adding when we generate a package, maybe its fixed as i have not upgraded in awhile.

@ryanbas21 ryanbas21 force-pushed the dedicated-token-store branch 3 times, most recently from 524cb60 to 810b121 Compare May 15, 2025 20:05
@ryanbas21 ryanbas21 force-pushed the dedicated-token-store branch from 810b121 to 5d9b3ad Compare May 16, 2025 20:16
@ryanbas21 ryanbas21 marked this pull request as ready for review May 16, 2025 20:18
@ryanbas21 ryanbas21 force-pushed the dedicated-token-store branch from 802cbb3 to f9ef5e3 Compare May 16, 2025 21:40
@ryanbas21 ryanbas21 merged commit 2b27bf8 into main May 19, 2025
4 checks passed
@ryanbas21 ryanbas21 mentioned this pull request May 16, 2025
@SteinGabriel SteinGabriel deleted the dedicated-token-store branch April 17, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants