chore: migrate-nx#571
Conversation
|
📝 WalkthroughWalkthroughUpdated development toolchain dependencies (nx and swc packages from various versions), added analytics disable setting to nx configuration, and expanded Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit ec8d214
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Around line 58-74: package.json dependency versions for the `@nx/`* and `@swc/`*
packages were bumped but pnpm-lock.yaml was not updated; run pnpm install (or
pnpm lock) locally to regenerate pnpm-lock.yaml so the lockfile reflects the new
versions (ensure entries for packages like "@nx/devkit", "@nx/workspace",
"@swc/core", "@swc/cli", "@swc-node/register", etc. appear), then add the
updated pnpm-lock.yaml to the commit and push the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9a1332a3-6409-4ff7-8d58-2dbc645048a4
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
.gitignorenx.jsonpackage.json
| "@nx/devkit": "22.6.5", | ||
| "@nx/eslint": "22.6.5", | ||
| "@nx/eslint-plugin": "22.6.5", | ||
| "@nx/express": "22.6.5", | ||
| "@nx/jest": "22.6.5", | ||
| "@nx/js": "22.6.5", | ||
| "@nx/playwright": "22.6.5", | ||
| "@nx/plugin": "22.6.5", | ||
| "@nx/vite": "22.6.5", | ||
| "@nx/vitest": "22.6.5", | ||
| "@nx/web": "22.6.5", | ||
| "@nx/workspace": "22.6.5", | ||
| "@playwright/test": "^1.47.2", | ||
| "@swc-node/register": "1.10.10", | ||
| "@swc/cli": "0.6.0", | ||
| "@swc/core": "1.11.21", | ||
| "@swc/helpers": "0.5.17", | ||
| "@swc-node/register": "1.11.1", | ||
| "@swc/cli": "0.7.10", | ||
| "@swc/core": "1.15.8", | ||
| "@swc/helpers": "0.5.21", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
test -f package.json || { echo "package.json not found"; exit 1; }
test -f pnpm-lock.yaml || { echo "pnpm-lock.yaml not found"; exit 1; }
python - <<'PY'
import json, sys
from pathlib import Path
pkg = json.loads(Path("package.json").read_text())
dev = pkg.get("devDependencies", {})
targets = [
"nx",
"@nx/devkit","@nx/eslint","@nx/eslint-plugin","@nx/express","@nx/jest","@nx/js",
"@nx/playwright","@nx/plugin","@nx/vite","@nx/vitest","@nx/web","@nx/workspace",
"@swc-node/register","@swc/cli","@swc/core","@swc/helpers","verdaccio"
]
missing = [t for t in targets if t not in dev]
if missing:
print("Missing from devDependencies:", missing)
sys.exit(2)
lock = Path("pnpm-lock.yaml").read_text()
not_in_lock = []
for name in targets:
ver = dev[name]
if f"{name}@{ver}:" not in lock:
not_in_lock.append((name, ver))
nx_versions = sorted({v for k, v in dev.items() if k == "nx" or k.startswith("@nx/")})
print("Distinct nx/@nx versions in package.json:", nx_versions)
if not_in_lock:
print("Expected entries not found in pnpm-lock.yaml:", not_in_lock)
sys.exit(3)
print("All expected bumped versions were found in pnpm-lock.yaml.")
PYRepository: ForgeRock/ping-javascript-sdk
Length of output: 599
pnpm-lock.yaml is out of sync with package.json; regenerate the lock file before merge.
The dependency versions in package.json (lines 58-74, 100, 115) have been bumped but are not reflected in pnpm-lock.yaml. All 16 packages checked—including all @nx/* packages (22.6.5) and @swc/* packages—are missing from the lock file with their updated versions. Run pnpm install or pnpm lock to regenerate the lock file and avoid install drift in CI.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` around lines 58 - 74, package.json dependency versions for the
`@nx/`* and `@swc/`* packages were bumped but pnpm-lock.yaml was not updated; run
pnpm install (or pnpm lock) locally to regenerate pnpm-lock.yaml so the lockfile
reflects the new versions (ensure entries for packages like "@nx/devkit",
"@nx/workspace", "@swc/core", "@swc/cli", "@swc-node/register", etc. appear),
then add the updated pnpm-lock.yaml to the commit and push the change.
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed e533d6d to https://ForgeRock.github.io/ping-javascript-sdk/pr-571/e533d6de73b0df3cef1e54195d427f8902604391 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/device-client - 0.0 KB (-9.7 KB, -100.0%) 📊 Minor Changes📈 @forgerock/device-client - 9.9 KB (+0.2 KB) ➖ No Changes➖ @forgerock/sdk-utilities - 11.2 KB 14 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (15.67%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
===========================================
- Coverage 70.90% 15.67% -55.24%
===========================================
Files 53 154 +101
Lines 2021 26666 +24645
Branches 377 1127 +750
===========================================
+ Hits 1433 4180 +2747
- Misses 588 22486 +21898 🚀 New features to boost your workflow:
|
3 participants
JIRA Ticket
N/A
Description
Update Nx library packages
Summary by CodeRabbit