Skip to content

chore: migrate-nx #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbas21 merged 1 commit into from
Apr 16, 2026
Merged

chore: migrate-nx #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,6 @@ test-output
# Gemini local knowledge base files
GEMINI.md
**/GEMINI.md

.claude/worktrees
.claude/settings.local.json
3 changes: 2 additions & 1 deletion nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,6 @@
"useInferencePlugins": true,
"defaultBase": "main",
"nxCloudId": "6762f3018aed9c5fad7009bb",
"$schema": "./node_modules/nx/schemas/nx-schema.json"
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"analytics": false
}
36 changes: 18 additions & 18 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,23 +55,23 @@
"@effect/cli": "catalog:effect",
"@eslint/eslintrc": "^3.0.0",
"@eslint/js": "~9.39.0",
"@nx/devkit": "22.3.3",
"@nx/eslint": "22.3.3",
"@nx/eslint-plugin": "22.3.3",
"@nx/express": "22.3.3",
"@nx/jest": "22.3.3",
"@nx/js": "22.3.3",
"@nx/playwright": "22.3.3",
"@nx/plugin": "22.3.3",
"@nx/vite": "22.3.3",
"@nx/vitest": "22.3.3",
"@nx/web": "22.3.3",
"@nx/workspace": "22.3.3",
"@nx/devkit": "22.6.5",
"@nx/eslint": "22.6.5",
"@nx/eslint-plugin": "22.6.5",
"@nx/express": "22.6.5",
"@nx/jest": "22.6.5",
"@nx/js": "22.6.5",
"@nx/playwright": "22.6.5",
"@nx/plugin": "22.6.5",
"@nx/vite": "22.6.5",
"@nx/vitest": "22.6.5",
"@nx/web": "22.6.5",
"@nx/workspace": "22.6.5",
"@playwright/test": "^1.47.2",
"@swc-node/register": "1.10.10",
"@swc/cli": "0.6.0",
"@swc/core": "1.11.21",
"@swc/helpers": "0.5.17",
"@swc-node/register": "1.11.1",
"@swc/cli": "0.7.10",
"@swc/core": "1.15.8",
"@swc/helpers": "0.5.21",
Comment on lines +58 to +74
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

test -f package.json || { echo "package.json not found"; exit 1; }
test -f pnpm-lock.yaml || { echo "pnpm-lock.yaml not found"; exit 1; }

python - <<'PY'
import json, sys
from pathlib import Path

pkg = json.loads(Path("package.json").read_text())
dev = pkg.get("devDependencies", {})

targets = [
  "nx",
  "@nx/devkit","@nx/eslint","@nx/eslint-plugin","@nx/express","@nx/jest","@nx/js",
  "@nx/playwright","@nx/plugin","@nx/vite","@nx/vitest","@nx/web","@nx/workspace",
  "@swc-node/register","@swc/cli","@swc/core","@swc/helpers","verdaccio"
]

missing = [t for t in targets if t not in dev]
if missing:
    print("Missing from devDependencies:", missing)
    sys.exit(2)

lock = Path("pnpm-lock.yaml").read_text()
not_in_lock = []
for name in targets:
    ver = dev[name]
    if f"{name}@{ver}:" not in lock:
        not_in_lock.append((name, ver))

nx_versions = sorted({v for k, v in dev.items() if k == "nx" or k.startswith("@nx/")})
print("Distinct nx/@nx versions in package.json:", nx_versions)

if not_in_lock:
    print("Expected entries not found in pnpm-lock.yaml:", not_in_lock)
    sys.exit(3)

print("All expected bumped versions were found in pnpm-lock.yaml.")
PY

Repository: ForgeRock/ping-javascript-sdk

Length of output: 599

pnpm-lock.yaml is out of sync with package.json; regenerate the lock file before merge.

The dependency versions in package.json (lines 58-74, 100, 115) have been bumped but are not reflected in pnpm-lock.yaml. All 16 packages checked—including all @nx/* packages (22.6.5) and @swc/* packages—are missing from the lock file with their updated versions. Run pnpm install or pnpm lock to regenerate the lock file and avoid install drift in CI.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` around lines 58 - 74, package.json dependency versions for the
`@nx/`* and `@swc/`* packages were bumped but pnpm-lock.yaml was not updated; run
pnpm install (or pnpm lock) locally to regenerate pnpm-lock.yaml so the lockfile
reflects the new versions (ensure entries for packages like "@nx/devkit",
"@nx/workspace", "@swc/core", "@swc/cli", "@swc-node/register", etc. appear),
then add the updated pnpm-lock.yaml to the commit and push the change.

"@types/eslint": "9.6.1",
"@types/estree": "^1.0.1",
"@types/express": "5.0.5",
Expand All @@ -97,7 +97,7 @@
"jsdom": "27.1.0",
"jsonc-eslint-parser": "^2.1.0",
"madge": "8.0.0",
"nx": "22.3.3",
"nx": "22.6.5",
"pkg-pr-new": "^0.0.60",
"playwright": "^1.47.2",
"prettier": "^3.2.5",
Expand All @@ -112,7 +112,7 @@
"typedoc-plugin-rename-defaults": "^0.7.2",
"typescript": "5.8.3",
"typescript-eslint": "^8.19.0",
"verdaccio": "6.2.1",
"verdaccio": "6.5.0",
"vite": "catalog:vite",
"vitest": "catalog:vitest",
"vitest-canvas-mock": "catalog:vitest"
Expand Down
Loading
Loading