fix: build all packages before snapshot publish by ryanbas21 · Pull Request #669 · ForgeRock/ping-javascript-sdk

ryanbas21 · 2026-06-03T17:23:44Z

Summary

The snapshot job was calling pnpm publish -r without first building all packages, causing packages to be published without dist/ directories
Added pnpm nx run-many -t build --no-agents --skip-nx-cache before the version step, matching the pattern already used by ci:release in the publish-or-pr job
--skip-nx-cache ensures builds use the freshly-versioned package.json rather than a stale cached artifact

Test plan

Trigger the snapshot workflow on a branch and confirm packages include dist/ directories

Summary by CodeRabbit

Chores
- Snapshot publishing workflow now includes an explicit build-all step before snapshot versioning and publishing.
- Ensures all packages are built prior to snapshot publication, reducing publish errors and improving overall release reliability.

changeset-bot · 2026-06-03T17:23:59Z

⚠️ No Changeset found

Latest commit: 1d0b6e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-06-03T17:23:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e5998c6c-0781-4594-b810-03b05fb4d8fc

📥 Commits

Reviewing files that changed from the base of the PR and between 1b20f18 and 1d0b6e9.

📒 Files selected for processing (1)

.github/workflows/publish.yml

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/publish.yml

📝 Walkthrough

Walkthrough

The PR inserts an explicit "Build all packages" step (pnpm nx run-many -t build --no-agents --skip-nx-cache) into the snapshot publish GitHub Actions workflow, running after project setup and before snapshot versioning and publishing.

Changes

Snapshot Publishing Workflow

Layer / File(s)	Summary
Explicit package build before publishing `.github/workflows/publish.yml`	Adds a new snapshot-job step that runs `pnpm nx run-many -t build --no-agents --skip-nx-cache` immediately after the "Setup Project" action and before snapshot versioning and publishing.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

ForgeRock/ping-javascript-sdk#497: Adds a build step to the publish workflow before publishing and changeset tagging using NX.
ForgeRock/ping-javascript-sdk#551: Modifies the NX multi-target build invocation in the publish flow, including --skip-nx-cache flag adjustments.
ForgeRock/ping-javascript-sdk#418: Introduced/centralized pnpm nx run-many build behavior in the publish flow.

Suggested reviewers

ancheetah
cerebrl

Poem

🐰 I hopped into CI with a careful little shove,
Built every package first, then pushed the snapshot above.
A tiny step in YAML, three lines neat and mild,
Now publish waits for artifacts—robust and reconciled. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a build step before snapshot publishing to ensure packages include dist/ directories.
Description check	✅ Passed	The description provides a clear summary, explanation of the issue, the solution implemented, and a test plan, though it does not include a JIRA ticket reference as specified in the template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/snapshot-missing-build-step

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-06-03T17:24:39Z

View your CI Pipeline Execution ↗ for commit 1d0b6e9

Command	Status	Duration	Result
`nx run-many -t build --no-agents`	✅ Succeeded	<1s	View ↗
`nx affected -t build lint test typecheck e2e-ci`	✅ Succeeded	8m	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-06-10 17:09:34 UTC

pkg-pr-new · 2026-06-03T17:32:10Z

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@669

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@669

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@669

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@669

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@669

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@669

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@669

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@669

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@669

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@669

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@669

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@669

commit: 1d0b6e9

github-actions · 2026-06-03T17:32:40Z

Deployed 73f782f to https://ForgeRock.github.io/ping-javascript-sdk/pr-669/73f782f957b6c16c744fa4364e9445be3258e033 branch gh-pages in ForgeRock/ping-javascript-sdk

codecov-commenter · 2026-06-03T17:32:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.20%. Comparing base (eafe277) to head (1d0b6e9).
⚠️ Report is 29 commits behind head on main.

❌ Your project status has failed because the head coverage (21.20%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   18.07%   21.20%   +3.13%     
==========================================
  Files         155      154       -1     
  Lines       24398    24838     +440     
  Branches     1203     1401     +198     
==========================================
+ Hits         4410     5268     +858     
+ Misses      19988    19570     -418

see 16 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-06-03T17:32:51Z

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/protect - 144.6 KB (new)
🆕 @forgerock/sdk-types - 7.9 KB (new)
🆕 @forgerock/device-client - 10.0 KB (new)
🆕 @forgerock/device-client - 0.0 KB (new)
🆕 @forgerock/iframe-manager - 2.4 KB (new)
🆕 @forgerock/storage - 1.5 KB (new)
🆕 @forgerock/sdk-request-middleware - 4.6 KB (new)
🆕 @forgerock/sdk-logger - 1.6 KB (new)
🆕 @forgerock/sdk-oidc - 5.7 KB (new)
🆕 @forgerock/journey-client - 93.0 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)
🆕 @forgerock/sdk-utilities - 11.2 KB (new)
🆕 @forgerock/davinci-client - 53.8 KB (new)
🆕 @forgerock/oidc-client - 30.5 KB (new)

14 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated

Current Size: Total gzipped size of all files in the package's dist directory
Baseline: Comparison against the latest build from the main branch
Files included: All build outputs except source maps and TypeScript build cache
Exclusions: .map, .tsbuildinfo, and .d.ts.map files

_{🔄 Updated automatically on each push to this PR}

vatsalparikh

Looks good!

chore: fix-snapshot

1d0b6e9

ryanbas21 force-pushed the fix/snapshot-missing-build-step branch from 1b20f18 to 1d0b6e9 Compare June 10, 2026 17:00

vatsalparikh approved these changes Jun 11, 2026

View reviewed changes

ancheetah approved these changes Jun 11, 2026

View reviewed changes

ryanbas21 merged commit 806da7c into main Jun 11, 2026
8 checks passed

ryanbas21 deleted the fix/snapshot-missing-build-step branch June 11, 2026 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: build all packages before snapshot publish#669

fix: build all packages before snapshot publish#669
ryanbas21 merged 1 commit into
mainfrom
fix/snapshot-missing-build-step

ryanbas21 commented Jun 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 3, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloud Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Jun 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

vatsalparikh left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

ryanbas21 commented Jun 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloud Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

Legend

Uh oh!

vatsalparikh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

ryanbas21 commented Jun 3, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Jun 3, 2026 •

edited

Loading

coderabbitai Bot commented Jun 3, 2026 •

edited

Loading

nx-cloud Bot commented Jun 3, 2026 •

edited

Loading

pkg-pr-new Bot commented Jun 3, 2026 •

edited

Loading

github-actions Bot commented Jun 3, 2026 •

edited

Loading

codecov-commenter commented Jun 3, 2026 •

edited

Loading

github-actions Bot commented Jun 3, 2026 •

edited

Loading