Skip to content

Port to Lean 4.31#828

Closed
lividgreen wants to merge 7 commits into
FormalizedFormalLogic:masterfrom
lividgreen:port-4.31
Closed

Port to Lean 4.31#828
lividgreen wants to merge 7 commits into
FormalizedFormalLogic:masterfrom
lividgreen:port-4.31

Conversation

@lividgreen

Copy link
Copy Markdown

I'm using Foundation for my own project. But I run Lean 4.31, so I had to port this with Claude for myself.
It IS AI-generated content, and I'm not an expert in Lean, so may be a good example of AI slop. But build is green.

I hope it is helpful rather than distracting.

Bump lean-toolchain to leanprover/lean4:v4.31.0, pin leanprover-community/mathlib to v4.31.0, refresh lake-manifest.
Foundational-layer drift: FunLike coe_injective' rename, Function.comp_def, Finset.toSet -> coercion, simpa defeq-boundary -> using!, non-inferrable instance -> def/lemma. No statements changed; no sorry.
v4.31 drift across Basic/Arithmetic/Bootstrapping/Completeness/Incompleteness/SetTheory/Skolemization: defeq-boundary crossings, zero_le now-implicit qualification, quote/typed-quote unfolds, instance -> def. Incompleteness theorems stay axiom-clean (no sorry); no statements changed.
v4.31 drift across Hilbert/Kripke/Neighborhood/FMT/Boolean/Entailment: SetLike rename, Finset.toSet -> coercion, simpa -> using!, grind/omega regressions, instance -> def/lemma. No statements changed; no sorry.
v4.31 drift across Hilbert/Kripke/Logic/Boxdot/Algebra/Modality: simpa defeq-boundary -> using!, Finset.toSet -> coercion, conditional/non-inferrable instance -> def/lemma, grind/omega/assumption regressions (trivial/simp/relation-unfold), match equation-gen -> Sum.elim, refine-from metavar fix. No statements changed; no sorry.
…apt to Lean/Mathlib v4.31.0

v4.31 drift: buildAxioms HasJ instance -> def, simpa -> using!, Finset.toSet -> coercion, grind regressions, letterless-realization simpa. No statements changed; no sorry.
Output of the required pre-submission step `lake exe mk_all --module`: updates the shake directive header (--deprecated_module: ignore) for v4.31. Import list unchanged.
@SnO2WMaN

SnO2WMaN commented Jun 29, 2026

Copy link
Copy Markdown
Member

Hello. We're currently planning to update to v4.31 after incorporating fixes such #823 by @iehality.
But, I also have a need to use features from v4.31 onward, I'm using @gotrevor's version (which was likewise revised by Claude) for the time being, and merge it in at an appropriate time.
We plan to maintain our attempt to further fork and revise the gotrevor's version as FFL at https://github.com/FormalizedFormalLogic/gotrevor-Foundation.

@gotrevor

gotrevor commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Thanks, @lividgreen . Though we're liklely using mine ( #830 ), this likely accelerated the process!

@SnO2WMaN SnO2WMaN closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants