Skip to content

Commit 3e88966

Browse files
author
Jan Guegel
committed
Merge remote-tracking branch 'origin/main' into auto-update-tab-after-extract
2 parents c2ea0bb + c50e835 commit 3e88966

4 files changed

Lines changed: 9 additions & 14 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88
### Fixed
99
- Fixed folders showing up incorrectly as files in copy/move dialog ([#267])
1010
- Fixed error when saving files with unsupported characters ([#250])
11-
- Fixed File manager does not ask for file access permission if opened for the first time via "share" dialog ([#85])
11+
- Fixed missing permission prompt on initial "Save as" launch ([#85])
1212

1313
## [1.2.3] - 2025-09-15
1414
### Fixed

app/src/main/kotlin/org/fossify/filemanager/activities/MainActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ class MainActivity : SimpleActivity() {
310310
}
311311
}
312312

313-
private fun initFileManager(refreshRecents: Boolean) {
313+
private fun initFileManager(refreshRecents: Boolean) {
314314
if (intent.action == Intent.ACTION_VIEW && intent.data != null) {
315315
val data = intent.data
316316
if (data?.scheme == "file") {

app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ import java.io.File
1515
class SaveAsActivity : SimpleActivity() {
1616
private val binding by viewBinding(ActivitySaveAsBinding::inflate)
1717

18-
19-
override fun onCreate(savedInstanceState: Bundle?) {
18+
override fun onCreate(savedInstanceState: Bundle?) {
2019
super.onCreate(savedInstanceState)
2120
setContentView(binding.root)
2221
tryInitFileManager()
@@ -32,6 +31,7 @@ class SaveAsActivity : SimpleActivity() {
3231
}
3332
}
3433
}
34+
3535
private fun saveAsDialog() {
3636
if (intent.action == Intent.ACTION_SEND && intent.extras?.containsKey(Intent.EXTRA_STREAM) == true) {
3737
FilePickerDialog(this, pickFile = false, showHidden = config.shouldShowHidden(), showFAB = true, showFavoritesButton = true) {

app/src/main/kotlin/org/fossify/filemanager/activities/SimpleActivity.kt

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,12 @@ open class SimpleActivity : BaseSimpleActivity() {
4545

4646
override fun getRepositoryName() = "File-Manager"
4747

48-
@SuppressLint("NewApi")
49-
override fun onActivityResult(requestCode: Int, resultCode: Int, dataIntent: Intent?) {
50-
super.onActivityResult(requestCode, resultCode, dataIntent)
51-
48+
@SuppressLint("NewApi")
49+
override fun onActivityResult(requestCode: Int, resultCode: Int, resultData: Intent?) {
50+
super.onActivityResult(requestCode, resultCode, resultData)
51+
isAskingPermissions = false
5252
if (requestCode == MANAGE_STORAGE_RC && isRPlus()) {
53-
if (Environment.isExternalStorageManager()) {
54-
recreate()
55-
} else {
56-
toast(R.string.no_storage_permissions)
57-
finish()
58-
}
53+
actionOnPermission?.invoke(Environment.isExternalStorageManager())
5954
}
6055
}
6156

0 commit comments

Comments
 (0)