Skip to content

Fix "Replace characters on save as function, FileNotFoundException" #250 #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 5 commits into from
Sep 26, 2025
Merged

Fix "Replace characters on save as function, FileNotFoundException" #250 #270

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a3ffcc
Fix "Replace characters on save as function, FileNotFoundException" #250
Sep 25, 2025
0b63f83
Update CHANGELOG.md
jguegel Sep 25, 2025
41d05cf
Update app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsA…
jguegel Sep 26, 2025
c7f6bf9
Update CHANGELOG.md
jguegel Sep 26, 2025
01a2dbd
Update CHANGELOG.md
jguegel Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
### Fixed
- Fixed folders showing up incorrectly as files in copy/move dialog ([#267])
- Fixed filename error in Save As-Dialog ([#50])
Comment thread
jguegel marked this conversation as resolved.
Outdated

## [1.2.3] - 2025-09-15
### Fixed
Expand Down Expand Up @@ -74,6 +75,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#176]: https://github.com/FossifyOrg/File-Manager/issues/176
[#251]: https://github.com/FossifyOrg/File-Manager/issues/251
[#267]: https://github.com/FossifyOrg/File-Manager/issues/267
[#250]: https://github.com/FossifyOrg/File-Manager/issues/250

Comment thread
jguegel marked this conversation as resolved.

[Unreleased]: https://github.com/FossifyOrg/File-Manager/compare/1.2.3...HEAD
[1.2.3]: https://github.com/FossifyOrg/File-Manager/compare/1.2.2...1.2.3
Expand Down
8 changes: 7 additions & 1 deletion app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ class SaveAsActivity : SimpleActivity() {
}

val source = intent.getParcelableExtra<Uri>(Intent.EXTRA_STREAM)!!
val filename = getFilenameFromContentUri(source)
val originalFilename = getFilenameFromContentUri(source)
?: source.toString().getFilenameFromPath()
val filename = sanitizeFilename(originalFilename)
val mimeType = contentResolver.getType(source)
?: intent.type?.takeIf { it != "*/*" }
?: filename.getMimeType()
Expand Down Expand Up @@ -66,4 +67,9 @@ class SaveAsActivity : SimpleActivity() {
super.onResume()
setupToolbar(binding.activitySaveAsToolbar, NavigationIcon.Arrow)
}

fun sanitizeFilename(filename: String): String {
Comment thread
jguegel marked this conversation as resolved.
Outdated
return filename.replace("[/\\\\<>:\"|?*\u0000-\u001F]".toRegex(), "_")
.takeIf { it.isNotBlank() } ?: "unnamed_file"
}
}
Loading