Skip to content

Fix file access permission if opened for the first time via "share" #85#271

Merged
naveensingh merged 19 commits intoFossifyOrg:mainfrom
jguegel:main
Sep 27, 2025
Merged

Fix file access permission if opened for the first time via "share" #85#271
naveensingh merged 19 commits intoFossifyOrg:mainfrom
jguegel:main

Conversation

@jguegel
Copy link
Copy Markdown
Contributor

@jguegel jguegel commented Sep 26, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Fixed file access permission if opened for the first time via "share"

Before & after preview

reuses the file permission view from mainactivity

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • All checks are passing.

Jan Guegel and others added 10 commits September 25, 2025 21:43
Fix "Replace characters on save as function, FileNotFoundException" #250
1a3ffcc
@jguegel
Update CHANGELOG.md
0b63f83 
update changelog
@jguegel @naveensingh
Update app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsA…
41d05cf 
…ctivity.kt

Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
@jguegel @naveensingh
Update CHANGELOG.md
c7f6bf9 
Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
@jguegel @naveensingh
Update CHANGELOG.md
01a2dbd 
Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
@jguegel
Merge branch 'FossifyOrg:main' into main
6085042
@jguegel
Merge branch 'FossifyOrg:main' into main
3528a95 
Signed-off-by: Jan Guegel <jan@guegel.eu>
Merge branch 'FossifyOrg:main' into main
24e156c 
Signed-off-by: Jan Guegel <jan@guegel.eu>
Merge remote-tracking branch 'origin/main'
e3bd385
@jguegel
Update CHANGELOG.md
21b2aaa
naveensingh
naveensingh requested changes Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be better and simpler to move handleStoragePermission() (and friends) from MainActivity to SimpleActivity and then reuse it in both places. Currently, we have duplicated code and no checks for pre-R devices.

Also, raise pull requests from a new branch every time instead of your main branch, and keep your main in sync before branching. That way, you'll avoid repushing the same commits in every pull request.

(Comments below are just bonus feedback)

Comment thread app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt Outdated
Comment thread app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt
@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Sep 26, 2025
Jan Guegel added 3 commits September 26, 2025 15:18
fix PR Feedback
204c879 
Signed-off-by: Jan Guegel <jan@guegel.eu>
Merge remote-tracking branch 'origin/main'
2a88a59
fix duplicated code by moving it to SimpleActivity.kt
1b67e61 
Signed-off-by: Jan Guegel <jan@guegel.eu>
@jguegel
Copy link
Copy Markdown
Contributor Author

jguegel commented Sep 26, 2025

yeah next PR will be from own branch then, still just playing around a bit
moved the method to simpleActivity like you suggested to avoid duplicated code

naveensingh
naveensingh requested changes Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you misunderstood my comment. Even after your changes:

  • The handleStoragePermission() method and related constants are still in MainActivity. They should be in SimpleActivity.
  • There's still duplicated code because handleStoragePermission() is not being reused in SaveAsActivity.
  • There's still no permission request for Android 10 and below versions in SaveAsActivity. Reusing the handleStoragePermission() method will also solve this.

Also, are you not testing your changes?

moved handleStoragePermissions() to SimpleActivity.kt from MainActivi…
2a5026e 
…ty.kt

introduced tryInitFileManager() to SaveAsActivity.kt
removed const MANAGE_STORAGE_RC from MainActivity.kt

Signed-off-by: Jan Guegel <jan@guegel.eu>
@jguegel
Copy link
Copy Markdown
Contributor Author

jguegel commented Sep 26, 2025

i am testing, just with android 16 and there it did work.
didnt know that older version behave differently there..
hopefully the latest commit should fix the issues

Jan Guegel added 2 commits September 26, 2025 16:37
adjusted toast in try catch in storage permission action
588a046 
Signed-off-by: Jan Guegel <jan@guegel.eu>
catch ActivityNotFoundException with fallback of SecurityException
0dcf18c 
Signed-off-by: Jan Guegel <jan@guegel.eu>
@jguegel
Copy link
Copy Markdown
Contributor Author

jguegel commented Sep 26, 2025

so i think i could fix it (and the linter is happy too)
sorry for the inconvenience... was struggling a bit more than i thought

@jguegel jguegel requested a review from naveensingh September 26, 2025 17:20
@naveensingh naveensingh removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Sep 27, 2025
naveensingh
naveensingh requested changes Sep 27, 2025
View reviewed changes
Comment thread app/src/main/kotlin/org/fossify/filemanager/activities/SimpleActivity.kt Outdated
Comment thread app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt Outdated
Comment thread app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt Outdated
Comment thread app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt
@jguegel @naveensingh
Apply suggestions from code review
e76565d 
thanks for the feedback!

Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
@jguegel jguegel requested a review from naveensingh September 27, 2025 05:51
remove indent
d6b7efb 
Signed-off-by: Jan Guegel <jan@guegel.eu>
naveensingh
naveensingh requested changes Sep 27, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated
@jguegel @naveensingh
adjust changelog
c50e835 
Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
naveensingh
naveensingh approved these changes Sep 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks.

@naveensingh naveensingh merged commit 223e644 into FossifyOrg:main Sep 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naveensingh naveensingh naveensingh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

File manager does not ask for file access permission if opened for the first time via "share" dialog

2 participants

@jguegel @naveensingh