Fix Search now ignores accents diacritics 95#274
Merged
naveensingh merged 18 commits intoFossifyOrg:mainfrom Sep 30, 2025
Merged
Fix Search now ignores accents diacritics 95#274naveensingh merged 18 commits intoFossifyOrg:mainfrom
naveensingh merged 18 commits intoFossifyOrg:mainfrom
Conversation
Signed-off-by: Jan Guegel <jan@guegel.eu>
…to ignore-accents-diacritics-95
Signed-off-by: Jan Guegel <jan@guegel.eu>
jguegel
changed the title
naveensingh
requested changes
Sep 28, 2025
naveensingh
added
the
waiting for author
Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
Signed-off-by: Jan Guegel <jan@guegel.eu>
Signed-off-by: Jan Guegel <jan@guegel.eu>
naveensingh
requested changes
Sep 28, 2025
Member
naveensingh
left a comment
naveensingh
left a comment
There was a problem hiding this comment.
Searches are now case-sensitive due to the switch to normalizeString().
Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
naveensingh
approved these changes
Sep 28, 2025
naveensingh
requested changes
Sep 28, 2025
Member
naveensingh
left a comment
naveensingh
left a comment
There was a problem hiding this comment.
You missed the MIME type browser launched from the storage tab.
Signed-off-by: Jan Guegel <jan@guegel.eu>
Contributor
Author
|
but now every location should be fixed.. maybe time for a proper nap |
Member
|
It is still broken. I'm really starting to feel like your tester here. Storage tab ➜ Expand Internal or SD Card ➜ Tap on Images/Videos/Other-types ➜ Tap the search button ➜ Search |
Contributor
Author
|
i am sorry.. that search i overlooked indeed.. looking into it now |
fix missing expection toast Signed-off-by: Jan Guegel <jan@guegel.eu>
naveensingh
removed
the
waiting for author
naveensingh
requested changes
Sep 30, 2025
Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
naveensingh
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Tests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).