add save as in menu in TextEditor

[jguegel]

Type of change(s)

• Bug fix
• Feature / enhancement
• Infrastructure / tooling (CI, build, deps, tests)
• Documentation

What changed and why

• add save as in menu
• rename saveText to saveAsText()
• add new save() without confirmation

Unsure about:

• added deprecation-Tag because otherwise I couldn't build locally

@Suppress("DEPRECATION")
startActivityForResult(this, requestCode)

• using same icon for Save and Save as
  Suggested idea, change order to:

1. Print displayed as Action ifRoom
2. Save As displayed as Action never
3. Open with displayed as Action never

Tests performed

• new Save-Button saves without confirmation
• Save As-Button uses old Save Logic

Before & after preview

• new "Save as"-menuItem in TextEditor

Closes the following issue(s)

• Closes Do not show Overwrite dialog when you're editing an already existing file and add "Save as" option #224

Checklist

• I read the contribution guidelines.
• I manually tested my changes on device/emulator (if applicable).
• I updated the "Unreleased" section in CHANGELOG.md (if applicable).
• I have self-reviewed my pull request (no typos, formatting errors, etc.).
• All checks are passing.

[naveensingh]

Bug-ish: It still displays a confirmation dialog when pressing back without saving and then pressing Save on the unsaved changes dialog.

[jguegel]

fixed the back button issue and applied your code review feedback.
hopefully the quality is getting better

[naveensingh]

hopefully the quality is getting better

Yeah, if you keep at it, you'll put me out of a job in a year or two.

[jguegel]

@naveensingh i am thinking about this, am i on the right track?

private fun isCloudFile(): Boolean {
    if (intent.data?.scheme == "content") {
        return true
    }
    
    return isRestrictedSAFOnlyRoot(filePath)
}

private fun saveText(shouldExitAfterSaving: Boolean = false) {
    updateFilePath()

    if (filePath.isEmpty() || isCloudFile()) {
        saveAsText(shouldExitAfterSaving)
    } else if (hasStoragePermission()) {
        val file = File(filePath)
        getFileOutputStream(file.toFileDirItem(this), true) {
            saveTextContent(it, shouldExitAfterSaving, true)
        }
    } else {
        toast(R.string.no_storage_permissions)
    }
}

it looks like intent.data?.scheme == "content" is always true...

[jguegel]

I can't find a proper solution and not sure how to test it, therefore i go with filePath.isEmpty() for now
idea, but not sure how to test, since my phone is not rooted neither to i have external content
if (filePath.isEmpty() || filePath == "external" || filePath == isRestrictedSAFOnlyRoot(filePath))

[naveensingh]

I'll fix it later, thanks.