fix: use incognito mode in checklists (#173)

* fix: use incognito mode in checklists

* fix: use an extension function to request incognito mode

Author: TopFox

app/src/main/kotlin/org/fossify/notes/dialogs/EditTaskDialog.kt

@@ -4,11 +4,13 @@ import android.app.Activity
 import android.content.DialogInterface.BUTTON_POSITIVE
 import org.fossify.commons.extensions.*
 import org.fossify.notes.databinding.DialogRenameChecklistItemBinding
+import org.fossify.notes.extensions.maybeRequestIncognito
 
 class EditTaskDialog(val activity: Activity, val oldTitle: String, callback: (newTitle: String) -> Unit) {
     init {
         val binding = DialogRenameChecklistItemBinding.inflate(activity.layoutInflater).apply {
             checklistItemTitle.setText(oldTitle)
+            checklistItemTitle.maybeRequestIncognito()
         }
 
         activity.getAlertDialogBuilder()

app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt

@@ -13,6 +13,7 @@ import org.fossify.notes.R
 import org.fossify.notes.databinding.DialogNewChecklistItemBinding
 import org.fossify.notes.databinding.ItemAddChecklistBinding
 import org.fossify.notes.extensions.config
+import org.fossify.notes.extensions.maybeRequestIncognito
 
 class NewChecklistItemDialog(
     val activity: Activity,
@@ -94,6 +95,9 @@ class NewChecklistItemDialog(
                 titles.add(titleEditText)
                 binding.checklistHolder.addView(this.root)
             }
+
+            titleEditText.maybeRequestIncognito()
+
             activity.updateTextColors(binding.checklistHolder)
             binding.dialogHolder.post {
                 binding.dialogHolder.fullScroll(View.FOCUS_DOWN)

app/src/main/kotlin/org/fossify/notes/extensions/TextView.kt

@@ -0,0 +1,13 @@
+package org.fossify.notes.extensions
+
+import android.view.inputmethod.EditorInfo
+import android.widget.TextView
+import org.fossify.commons.extensions.removeBit
+
+fun TextView.maybeRequestIncognito() {
+    imeOptions = if (context.config.useIncognitoMode) {
+        imeOptions or EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING
+    } else {
+        imeOptions.removeBit(EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING)
+    }
+}

app/src/main/kotlin/org/fossify/notes/fragments/TextFragment.kt

@@ -14,7 +14,6 @@ import android.view.LayoutInflater
 import android.view.MotionEvent
 import android.view.View
 import android.view.ViewGroup
-import android.view.inputmethod.EditorInfo
 import android.view.inputmethod.InputMethodManager
 import android.widget.ImageView
 import android.widget.TextView
@@ -29,6 +28,7 @@ import org.fossify.notes.databinding.NoteViewStaticBinding
 import org.fossify.notes.extensions.config
 import org.fossify.notes.extensions.enforcePlainText
 import org.fossify.notes.extensions.getPercentageFontSize
+import org.fossify.notes.extensions.maybeRequestIncognito
 import org.fossify.notes.extensions.updateWidgets
 import org.fossify.notes.helpers.MyMovementMethod
 import org.fossify.notes.helpers.NOTE_ID
@@ -175,12 +175,7 @@ class TextFragment : NoteFragment() {
                     }
                 }
             }
-
-            imeOptions = if (config.useIncognitoMode) {
-                imeOptions or EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING
-            } else {
-                imeOptions.removeBit(EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING)
-            }
+            maybeRequestIncognito()
         }
 
         noteEditText.setOnTouchListener { v, event ->