chore: ignore extra translations and update detekt rules

* chore: ignore extra translations in lint

Extra translations are removed automatically by Weblate

* chore: update detekt rules

More compose-friendly

* chore: update lint baselines

Author: naveensingh

app/build.gradle.kts

@@ -131,6 +131,9 @@ android {
 
 detekt {
     baseline = file("detekt-baseline.xml")
+    config.setFrom("$rootDir/detekt.yml")
+    buildUponDefaultConfig = true
+    allRules = false
 }
 
 dependencies {
@@ -141,4 +144,5 @@ dependencies {
 
     implementation(libs.bundles.room)
     ksp(libs.androidx.room.compiler)
+    detektPlugins(libs.compose.detekt)
 }

app/detekt-baseline.xml

@@ -11,14 +11,11 @@
     <ID>EmptyFunctionBlock:TasksAdapter.kt$TasksAdapter${}</ID>
     <ID>EmptyFunctionBlock:WidgetAdapter.kt$WidgetAdapter${}</ID>
     <ID>LargeClass:MainActivity.kt$MainActivity : SimpleActivity</ID>
-    <ID>LongMethod:Context.kt$fun Context.backupNotes()</ID>
     <ID>MagicNumber:AutomaticBackupReceiver.kt$AutomaticBackupReceiver$3000</ID>
     <ID>MagicNumber:Config.kt$Config$100</ID>
     <ID>MagicNumber:Constants.kt$6</ID>
     <ID>MagicNumber:Context.kt$100f</ID>
-    <ID>MagicNumber:ImportFolderDialog.kt$ImportFolderDialog$1000</ID>
     <ID>MagicNumber:MainActivity.kt$MainActivity$0.4f</ID>
-    <ID>MagicNumber:MainActivity.kt$MainActivity$1000</ID>
     <ID>MagicNumber:MainActivity.kt$MainActivity$127</ID>
     <ID>MagicNumber:MainActivity.kt$MainActivity$250</ID>
     <ID>MagicNumber:MainActivity.kt$MainActivity$255</ID>

app/lint-baseline.xml

@@ -14,8 +14,8 @@
         errorLine1="app-build-targetSDK = "34""
         errorLine2="                      ~~~~">
         <location
-            file="$HOME/work/Notes/Notes/gradle/libs.versions.toml"
-            line="20"
+            file="$HOME/Projects/Fossify/FossifyOrg/Notes/gradle/libs.versions.toml"
+            line="21"
             column="23"/>
     </issue>
 
@@ -80,7 +80,7 @@
         errorLine1="distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip"
         errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
         <location
-            file="$HOME/work/Notes/Notes/gradle/wrapper/gradle-wrapper.properties"
+            file="$HOME/Projects/Fossify/FossifyOrg/Notes/gradle/wrapper/gradle-wrapper.properties"
             line="3"
             column="17"/>
     </issue>
@@ -91,8 +91,8 @@
         errorLine1="gradlePlugins-agp = &quot;8.10.1&quot;"
         errorLine2="                    ~~~~~~~~">
         <location
-            file="$HOME/work/Notes/Notes/gradle/libs.versions.toml"
-            line="17"
+            file="$HOME/Projects/Fossify/FossifyOrg/Notes/gradle/libs.versions.toml"
+            line="18"
             column="21"/>
     </issue>
 
@@ -102,8 +102,8 @@
         errorLine1="app-build-compileSDKVersion = &quot;34&quot;"
         errorLine2="                              ~~~~">
         <location
-            file="$HOME/work/Notes/Notes/gradle/libs.versions.toml"
-            line="19"
+            file="$HOME/Projects/Fossify/FossifyOrg/Notes/gradle/libs.versions.toml"
+            line="20"
             column="31"/>
     </issue>
 

detekt.yml

@@ -0,0 +1,58 @@
+build:
+  maxIssues: 0
+  weights:
+    complexity: 2
+    LongParameterList: 2
+    style: 1
+
+processors:
+  active: true
+  exclude:
+    - "FunctionCountProcessor"
+    - "PropertyCountProcessor"
+
+config:
+  validation: true
+
+complexity:
+  LongParameterList:
+    active: true
+    functionThreshold: 10
+    constructorThreshold: 8
+    ignoreDefaultParameters: true
+    ignoreAnnotated:
+      - "Composable"
+  LongMethod:
+    active: true
+    threshold: 120
+    ignoreAnnotated:
+      - "Composable"
+      - "Preview"
+
+style:
+  MagicNumber:
+    active: true
+    ignoreAnnotated: ["Composable"]
+    ignoreEnums: true
+    ignoreNumbers: ["-1", "0", "1", "2", "42", "1000"]
+  MaxLineLength:
+    active: true
+    maxLineLength: 120
+    excludePackageStatements: true
+    excludeImportStatements: true
+
+naming:
+  FunctionNaming:
+    active: true
+    ignoreAnnotated: ["Composable", "Preview"]
+    functionPattern: "[a-z][A-Za-z0-9]*"
+
+Compose: # io.nlopez.compose.rules
+  ComposableParametersOrdering:
+    active: true
+  ModifierDefaultValue:
+    active: true
+  MissingModifierDefaultValue:
+    active: true
+  PublicComposablePreview:
+    active: true

gradle/libs.versions.toml

@@ -6,6 +6,7 @@ kotlinxSerializationJson = "1.8.1"
 ksp = "2.1.21-2.0.2"
 #Detekt
 detekt = "1.23.8"
+detektCompose = "0.4.22"
 #AndroidX
 androidx-constraintlayout = "2.2.1"
 androidx-documentfile = "1.1.0"
@@ -29,6 +30,8 @@ androidx-documentfile = { module = "androidx.documentfile:documentfile", version
 androidx-room-runtime = { module = "androidx.room:room-runtime", version.ref = "room" }
 androidx-room-ktx = { module = "androidx.room:room-ktx", version.ref = "room" }
 androidx-room-compiler = { module = "androidx.room:room-compiler", version.ref = "room" }
+#Compose
+compose-detekt = { module = "io.nlopez.compose.rules:detekt", version.ref = "detektCompose" }
 #Fossify
 fossify-commons = { module = "org.fossify:commons", version.ref = "commons" }
 #Kotlin

lint.xml

@@ -31,4 +31,5 @@
     <issue id="IconDensities" severity="warning" />
     <issue id="GradleDependency" severity="warning" />
     <issue id="Overdraw" severity="warning" />
+    <issue id="ExtraTranslation" severity="warning" />
 </lint>