Skip to content

fix: make eraser size relative to zoom and consistent with brush #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 3 commits into from
Apr 20, 2025
Merged

fix: make eraser size relative to zoom and consistent with brush #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2c8f40
fix eraser zoom
Douniahlt Apr 19, 2025
b3e2769
Merge branch 'FossifyOrg:master' into master
Douniahlt Apr 19, 2025
9489a23
remove unused MIN_ERASER_WIDTH after eraser size logic update
Douniahlt Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/src/main/kotlin/org/fossify/paint/views/MyCanvas.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import java.util.concurrent.ExecutionException
import kotlin.math.abs

class MyCanvas(context: Context, attrs: AttributeSet) : View(context, attrs) {
private val MIN_ERASER_WIDTH = 20f
private val MAX_HISTORY_COUNT = 1000
private val FLOOD_FILL_TOLERANCE = 1

Expand Down Expand Up @@ -334,9 +333,6 @@ class MyCanvas(context: Context, attrs: AttributeSet) : View(context, attrs) {
private fun changePaint(paintOptions: PaintOptions) {
mPaint.color = if (paintOptions.isEraser) mBackgroundColor else paintOptions.color
mPaint.strokeWidth = paintOptions.strokeWidth
if (paintOptions.isEraser && mPaint.strokeWidth < MIN_ERASER_WIDTH) {
mPaint.strokeWidth = MIN_ERASER_WIDTH
}
}

fun clearCanvas() {
Expand Down