Skip to content

Commit 686c12f

Browse files
Ammar64naveensingh
andauthored
fix: enforce ltr direction for phone numbers (#399)
* Fix phone number text direction * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com> * Update item_filter_contact_source.xml * Update call_notification.xml --------- Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
1 parent ca3764f commit 686c12f

6 files changed

Lines changed: 12 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
### Fixed
11+
- Fixed phone number text direction in RTL layout ([#307])
12+
1013
## [1.4.0] - 2025-04-01
1114

1215
### Added

app/src/main/res/layout/activity_call.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
app:layout_constraintEnd_toStartOf="@+id/on_hold_label"
4141
app:layout_constraintStart_toEndOf="@+id/imageView"
4242
app:layout_constraintTop_toTopOf="parent"
43+
android:textDirection="firstStrongLtr"
4344
tools:text="0912 345 678" />
4445

4546
<org.fossify.commons.views.MyTextView
@@ -86,6 +87,7 @@
8687
app:layout_constraintEnd_toEndOf="parent"
8788
app:layout_constraintStart_toStartOf="parent"
8889
app:layout_constraintTop_toBottomOf="@id/caller_avatar"
90+
android:textDirection="firstStrongLtr"
8991
tools:text="Caller name" />
9092

9193
<org.fossify.commons.views.MyTextView
@@ -99,6 +101,7 @@
99101
app:layout_constraintEnd_toEndOf="parent"
100102
app:layout_constraintStart_toStartOf="parent"
101103
app:layout_constraintTop_toBottomOf="@+id/caller_name_label"
104+
android:textDirection="firstStrongLtr"
102105
tools:text="+1 (123) 456-7890" />
103106

104107
<org.fossify.commons.views.MyTextView

app/src/main/res/layout/call_notification.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
xmlns:tools="http://schemas.android.com/tools"
44
android:id="@+id/notification_holder"
55
android:layout_width="match_parent"
6-
android:layout_height="match_parent">
6+
android:layout_height="match_parent"
7+
tools:background="#fff">
78

89
<TextView
910
android:id="@+id/notification_caller_name"
@@ -12,6 +13,7 @@
1213
android:layout_height="wrap_content"
1314
android:textSize="@dimen/bigger_text_size"
1415
android:textStyle="bold"
16+
android:textDirection="firstStrongLtr"
1517
tools:text="Caller name" />
1618

1719
<TextView

app/src/main/res/layout/item_conference_call.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
android:ellipsize="end"
2828
android:maxLines="1"
2929
android:textSize="@dimen/bigger_text_size"
30+
android:textDirection="firstStrongLtr"
3031
app:layout_constraintBottom_toBottomOf="@+id/item_conference_call_image"
3132
app:layout_constraintEnd_toStartOf="@+id/item_conference_call_split"
3233
app:layout_constraintStart_toEndOf="@+id/item_conference_call_image"

app/src/main/res/layout/item_recent_call.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
android:ellipsize="end"
3333
android:maxLines="1"
3434
android:textAlignment="viewStart"
35-
android:textDirection="locale"
35+
android:textDirection="firstStrongLtr"
3636
android:textSize="@dimen/bigger_text_size"
3737
app:layout_constraintBottom_toTopOf="@id/item_recents_date_time"
3838
app:layout_constraintEnd_toStartOf="@+id/overflow_menu_icon"

app/src/main/res/layout/item_speed_dial.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,5 @@
1111
android:maxLines="1"
1212
android:padding="@dimen/activity_margin"
1313
android:singleLine="true"
14+
android:textDirection="firstStrongLtr"
1415
android:textSize="@dimen/bigger_text_size" />

0 commit comments

Comments
 (0)