Skip to content

implements #114#218

Closed
Honk2 wants to merge 10 commits into
FossifyOrg:mainfrom
Honk2:implement-114
Closed

implements #114#218
Honk2 wants to merge 10 commits into
FossifyOrg:mainfrom
Honk2:implement-114

Conversation

@Honk2
Copy link
Copy Markdown
Contributor

@Honk2 Honk2 commented Aug 3, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • added option to show/hide contact images as in contacts app

Fixes the following issue(s)

Acknowledgement

@Aga-C
Copy link
Copy Markdown
Contributor

Aga-C commented Aug 4, 2024

  1. In Call History, there's a missing left margin for items. Please adjust it like it is in the other tabs.
  2. What is the source of the translated strings?

@Honk2
Copy link
Copy Markdown
Contributor Author

Honk2 commented Aug 4, 2024

  1. Ok, I adjusted the padding/margin of the call history to the same as in the contacts list
  2. The strings are copied from the contacts app.

@naveensingh naveensingh self-assigned this May 26, 2025
Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings are copied from the contacts app.

I resolved the conflicts, but it's better to move those strings to commons instead of duplicating them here.

Also, the code stopped compiling after this merge commit.

@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Jun 5, 2025
@naveensingh naveensingh removed their assignment Jun 9, 2025
@fossifybot
Copy link
Copy Markdown
Contributor

fossifybot Bot commented Jun 19, 2025

This pull request was automatically closed due to inactivity and/or lack of response from the author. If you have further updates or additional information, please comment or reopen the PR to continue.

@fossifybot fossifybot Bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Jun 19, 2025
@fossifybot fossifybot Bot closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

low priority feature req: Phone Thumbnails - allow to disable

3 participants