Skip to content

WIP: Initial support for sim colors#27

Merged
naveensingh merged 8 commits into
FossifyOrg:masterfrom
derrohrbach:sim-color
Jun 5, 2025
Merged

WIP: Initial support for sim colors#27
naveensingh merged 8 commits into
FossifyOrg:masterfrom
derrohrbach:sim-color

Conversation

@derrohrbach
Copy link
Copy Markdown
Contributor

@derrohrbach derrohrbach commented Jan 17, 2024

Here is my initial draft for sim color support. Feel free to already comment on it. Things left to do:

  • Move sim color conversions to commons library, so we can use it in SMS app too
  • Test with more designs
  • Check/Work on CallActivity and ConferenceActivity
  • Maybe also rework SelectSIMDialog (most likely seperate PR)

This fixes/implements: SimpleMobileTools/Simple-Dialer#322

@naveensingh
Copy link
Copy Markdown
Member

@derrohrbach I'll check this soon...

If the PR isn't ready to merge yet, you can convert it to a draft PR to signal that.

@derrohrbach derrohrbach marked this pull request as draft January 22, 2024 21:04
@derrohrbach
Copy link
Copy Markdown
Contributor Author

@naveensingh Hey, thanks. I did not know that, since I'm used to the GitLab workflow where you just name your MR "WIP".

@derrohrbach
Copy link
Copy Markdown
Contributor Author

Only thing missing is moving the extension function to the common library. What is the workflow for that? Do I first submit a PR there and wait for a version to be built/published so i can update the reference in this project?

Or should I just copy this one function over to the SMS app?

@naveensingh
Copy link
Copy Markdown
Member

naveensingh commented Mar 17, 2024

@derrohrbach

What is the workflow for that? Do I first submit a PR there and wait for a version to be built/published so i can update the reference in this project?

Please raise a PR in Commons. Once the PR is merged, anyone can trigger a Jitpack build at this page: https://jitpack.io/#org.fossify/commons/

@naveensingh naveensingh added waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. and removed waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Nov 23, 2024
@naveensingh naveensingh self-assigned this May 26, 2025
@naveensingh naveensingh marked this pull request as ready for review June 5, 2025 09:14
Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine, thanks!

@naveensingh naveensingh merged commit 7cb420b into FossifyOrg:master Jun 5, 2025
3 of 5 checks passed
@derrohrbach
Copy link
Copy Markdown
Contributor Author

Hey, thanks for finishing this! I had literally no time to work on this lately, sorry!

@naveensingh
Copy link
Copy Markdown
Member

No problem! Just polished it a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants