Fix phone number text direction

[Ammar64]

Type of change(s)

• Bug fix

What changed and why

• Changed the android:textDirection of TextViews, that holds the phone number or contact name, to firstStrongLtr

Before/After Screenshots/Screen Record

Before	After

Fixes the following issue(s)

• Fixes Reverse phone number in rtl #307

Checklist

• I read the contribution guidelines.
• I updated the "Unreleased" section in CHANGELOG.md (if applicable).
• I manually tested my changes on device/emulator (if applicable).

[Ammar64]

Your bot missed up the screenshots

[naveensingh]

Your bot missed up the screenshots

He doesn't like tables. Another thing that needs fixing.

If you just drop your screenshots, they'll be minimized properly.

[naveensingh]

I noticed you have done this for fields that do not hold any numeric values, e.g., notification_call_status. Is there any reason for that?

[Ammar64]

I noticed you have done this for fields that do not hold any numeric values, e.g., notification_call_status. Is there any reason for that?

I made the change to all TextViews that I thought they may hold phone number.
For an example item_recents_name shows the contact name when available, but if there is no contact name it shows the phone number.
As for notification_call_status I don't remember where does it show up, but since I changed it, it means the I thought it would hold a phone number back then.

[naveensingh]

notification_call_status is for call status, not a number:

Phone/app/src/main/kotlin/org/fossify/phone/helpers/CallNotificationManager.kt

Lines 64 to 74 in ca3764f

	val contentTextId = when (callState) {
	Call.STATE_RINGING -> R.string.is_calling
	Call.STATE_DIALING -> R.string.dialing
	Call.STATE_DISCONNECTED -> R.string.call_ended
	Call.STATE_DISCONNECTING -> R.string.call_ending
	else -> R.string.ongoing_call
	}
	val collapsedView = RemoteViews(context.packageName, R.layout.call_notification).apply {
	setText(R.id.notification_caller_name, callerName)
	setText(R.id.notification_call_status, context.getString(contentTextId))

Same deal with filter_contact_source_checkbox.

[Ammar64]

notification_call_status is for call status, not a number:

I've fixed them now.
It wouldn't cause issues though.

[naveensingh]

Thanks. Let's hope nobody uses emojis as name prefix.