Skip to content

Commit ce91c20

Browse files
authored
feat: add recording section to settings (#149)
* feat: add recording section label to settings * feat: move audio source preference to the bottom * docs: update changelog
1 parent 831e426 commit ce91c20

3 files changed

Lines changed: 37 additions & 23 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414
### Changed
1515

1616
- Improved wording in the recording cancellation dialog ([#141])
17+
- Moved recording-related preferences to a new "Recording" section ([#147])
1718
- Updated translations
1819

1920
## [1.2.0] - 2025-05-20
@@ -100,3 +101,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
100101
[#81]: https://github.com/FossifyOrg/Voice-Recorder/issues/81
101102
[#106]: https://github.com/FossifyOrg/Voice-Recorder/issues/106
102103
[#141]: https://github.com/FossifyOrg/Voice-Recorder/issues/141
104+
[#147]: https://github.com/FossifyOrg/Voice-Recorder/issues/147

app/src/main/kotlin/org/fossify/voicerecorder/activities/SettingsActivity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ class SettingsActivity : SimpleActivity() {
9191
arrayOf(
9292
binding.settingsColorCustomizationSectionLabel,
9393
binding.settingsGeneralSettingsLabel,
94+
binding.settingsRecordingSectionLabel,
9495
binding.settingsRecycleBinLabel
9596
).forEach {
9697
it.setTextColor(getProperPrimaryColor())

app/src/main/res/layout/activity_settings.xml

Lines changed: 34 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,17 @@
163163

164164
</RelativeLayout>
165165

166+
<include
167+
android:id="@+id/settings_general_settings_divider"
168+
layout="@layout/divider" />
169+
170+
<TextView
171+
android:id="@+id/settings_recording_section_label"
172+
style="@style/SettingsSectionLabelStyle"
173+
android:layout_width="match_parent"
174+
android:layout_height="wrap_content"
175+
android:text="@string/recording" />
176+
166177
<RelativeLayout
167178
android:id="@+id/settings_record_after_launch_holder"
168179
style="@style/SettingsHolderSwitchStyle"
@@ -216,28 +227,6 @@
216227

217228
</RelativeLayout>
218229

219-
<RelativeLayout
220-
android:id="@+id/settings_audio_source_holder"
221-
style="@style/SettingsHolderTextViewStyle"
222-
android:layout_width="match_parent"
223-
android:layout_height="wrap_content">
224-
225-
<org.fossify.commons.views.MyTextView
226-
android:id="@+id/settings_audio_source_label"
227-
style="@style/SettingsTextLabelStyle"
228-
android:layout_width="wrap_content"
229-
android:layout_height="wrap_content"
230-
android:text="@string/audio_source" />
231-
232-
<org.fossify.commons.views.MyTextView
233-
android:id="@+id/settings_audio_source"
234-
style="@style/SettingsTextValueStyle"
235-
android:layout_width="match_parent"
236-
android:layout_height="wrap_content"
237-
android:layout_below="@+id/settings_audio_source_label"
238-
tools:text="Camera" />
239-
</RelativeLayout>
240-
241230
<RelativeLayout
242231
android:id="@+id/settings_extension_holder"
243232
style="@style/SettingsHolderTextViewStyle"
@@ -307,8 +296,30 @@
307296

308297
</RelativeLayout>
309298

299+
<RelativeLayout
300+
android:id="@+id/settings_audio_source_holder"
301+
style="@style/SettingsHolderTextViewStyle"
302+
android:layout_width="match_parent"
303+
android:layout_height="wrap_content">
304+
305+
<org.fossify.commons.views.MyTextView
306+
android:id="@+id/settings_audio_source_label"
307+
style="@style/SettingsTextLabelStyle"
308+
android:layout_width="wrap_content"
309+
android:layout_height="wrap_content"
310+
android:text="@string/audio_source" />
311+
312+
<org.fossify.commons.views.MyTextView
313+
android:id="@+id/settings_audio_source"
314+
style="@style/SettingsTextValueStyle"
315+
android:layout_width="match_parent"
316+
android:layout_height="wrap_content"
317+
android:layout_below="@+id/settings_audio_source_label"
318+
tools:text="Camera" />
319+
</RelativeLayout>
320+
310321
<include
311-
android:id="@+id/settings_general_settings_divider"
322+
android:id="@+id/settings_recording_divider"
312323
layout="@layout/divider" />
313324

314325
<TextView

0 commit comments

Comments
 (0)