Skip to content

feat: add recording section to settings #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 3 commits into from
Jun 10, 2025
+37 −23
Merged

feat: add recording section to settings #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c948ffb
feat: add recording section label to settings
naveensingh Jun 10, 2025
79cab5d
feat: move audio source preference to the bottom
naveensingh Jun 10, 2025
21ba4d1
docs: update changelog
naveensingh Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Improved wording in the recording cancellation dialog ([#141])
- Moved recording-related preferences to a new "Recording" section ([#147])
- Updated translations

## [1.2.0] - 2025-05-20
Expand Down Expand Up @@ -100,3 +101,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#81]: https://github.com/FossifyOrg/Voice-Recorder/issues/81
[#106]: https://github.com/FossifyOrg/Voice-Recorder/issues/106
[#141]: https://github.com/FossifyOrg/Voice-Recorder/issues/141
[#147]: https://github.com/FossifyOrg/Voice-Recorder/issues/147
1 change: 1 addition & 0 deletions app/src/main/kotlin/org/fossify/voicerecorder/activities/SettingsActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ class SettingsActivity : SimpleActivity() {
arrayOf(
binding.settingsColorCustomizationSectionLabel,
binding.settingsGeneralSettingsLabel,
binding.settingsRecordingSectionLabel,
binding.settingsRecycleBinLabel
).forEach {
it.setTextColor(getProperPrimaryColor())
Expand Down
57 changes: 34 additions & 23 deletions app/src/main/res/layout/activity_settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,17 @@

</RelativeLayout>

<include
android:id="@+id/settings_general_settings_divider"
layout="@layout/divider" />

<TextView
android:id="@+id/settings_recording_section_label"
style="@style/SettingsSectionLabelStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="@string/recording" />

<RelativeLayout
android:id="@+id/settings_record_after_launch_holder"
style="@style/SettingsHolderSwitchStyle"
Expand Down Expand Up @@ -216,28 +227,6 @@

</RelativeLayout>

<RelativeLayout
android:id="@+id/settings_audio_source_holder"
style="@style/SettingsHolderTextViewStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content">

<org.fossify.commons.views.MyTextView
android:id="@+id/settings_audio_source_label"
style="@style/SettingsTextLabelStyle"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/audio_source" />

<org.fossify.commons.views.MyTextView
android:id="@+id/settings_audio_source"
style="@style/SettingsTextValueStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_below="@+id/settings_audio_source_label"
tools:text="Camera" />
</RelativeLayout>

<RelativeLayout
android:id="@+id/settings_extension_holder"
style="@style/SettingsHolderTextViewStyle"
Expand Down Expand Up @@ -307,8 +296,30 @@

</RelativeLayout>

<RelativeLayout
android:id="@+id/settings_audio_source_holder"
style="@style/SettingsHolderTextViewStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content">

<org.fossify.commons.views.MyTextView
android:id="@+id/settings_audio_source_label"
style="@style/SettingsTextLabelStyle"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/audio_source" />

<org.fossify.commons.views.MyTextView
android:id="@+id/settings_audio_source"
style="@style/SettingsTextValueStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_below="@+id/settings_audio_source_label"
tools:text="Camera" />
</RelativeLayout>

<include
android:id="@+id/settings_general_settings_divider"
android:id="@+id/settings_recording_divider"
layout="@layout/divider" />

<TextView
Expand Down
Loading