diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e4ceace..70441d83 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Moved recording-related preferences to a new "Recording" section ([#147]) - Updated translations +### Removed + +- Removed outdated option for hiding notification ([#150]) + ## [1.2.0] - 2025-05-20 ### Added @@ -102,3 +106,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 [#106]: https://github.com/FossifyOrg/Voice-Recorder/issues/106 [#141]: https://github.com/FossifyOrg/Voice-Recorder/issues/141 [#147]: https://github.com/FossifyOrg/Voice-Recorder/issues/147 +[#150]: https://github.com/FossifyOrg/Voice-Recorder/issues/150 diff --git a/app/src/main/kotlin/org/fossify/voicerecorder/activities/SettingsActivity.kt b/app/src/main/kotlin/org/fossify/voicerecorder/activities/SettingsActivity.kt index e900af12..1caf9585 100644 --- a/app/src/main/kotlin/org/fossify/voicerecorder/activities/SettingsActivity.kt +++ b/app/src/main/kotlin/org/fossify/voicerecorder/activities/SettingsActivity.kt @@ -76,7 +76,6 @@ class SettingsActivity : SimpleActivity() { setupUseEnglish() setupLanguage() setupChangeDateTimeFormat() - setupHideNotification() setupSaveRecordingsFolder() setupExtension() setupBitrate() @@ -152,14 +151,6 @@ class SettingsActivity : SimpleActivity() { } } - private fun setupHideNotification() { - binding.settingsHideNotification.isChecked = config.hideNotification - binding.settingsHideNotificationHolder.setOnClickListener { - binding.settingsHideNotification.toggle() - config.hideNotification = binding.settingsHideNotification.isChecked - } - } - private fun setupSaveRecordingsFolder() { binding.settingsSaveRecordingsLabel.text = addLockedLabelIfNeeded(R.string.save_recordings_in) diff --git a/app/src/main/kotlin/org/fossify/voicerecorder/helpers/Config.kt b/app/src/main/kotlin/org/fossify/voicerecorder/helpers/Config.kt index 41950c9e..c0b027bf 100644 --- a/app/src/main/kotlin/org/fossify/voicerecorder/helpers/Config.kt +++ b/app/src/main/kotlin/org/fossify/voicerecorder/helpers/Config.kt @@ -12,10 +12,6 @@ class Config(context: Context) : BaseConfig(context) { fun newInstance(context: Context) = Config(context) } - var hideNotification: Boolean - get() = prefs.getBoolean(HIDE_NOTIFICATION, false) - set(hideNotification) = prefs.edit().putBoolean(HIDE_NOTIFICATION, hideNotification).apply() - var saveRecordingsFolder: String get() = prefs.getString(SAVE_RECORDINGS, context.getDefaultRecordingsFolder())!! set(saveRecordingsFolder) = prefs.edit().putString(SAVE_RECORDINGS, saveRecordingsFolder) diff --git a/app/src/main/kotlin/org/fossify/voicerecorder/helpers/Constants.kt b/app/src/main/kotlin/org/fossify/voicerecorder/helpers/Constants.kt index 4a3b5dcc..05e3a3a2 100644 --- a/app/src/main/kotlin/org/fossify/voicerecorder/helpers/Constants.kt +++ b/app/src/main/kotlin/org/fossify/voicerecorder/helpers/Constants.kt @@ -90,7 +90,6 @@ const val IS_RECORDING = "is_recording" const val TOGGLE_WIDGET_UI = "toggle_widget_ui" // shared preferences -const val HIDE_NOTIFICATION = "hide_notification" const val SAVE_RECORDINGS = "save_recordings" const val EXTENSION = "extension" const val AUDIO_SOURCE = "audio_source" diff --git a/app/src/main/kotlin/org/fossify/voicerecorder/services/RecorderService.kt b/app/src/main/kotlin/org/fossify/voicerecorder/services/RecorderService.kt index 2ff795a8..80cc41ef 100644 --- a/app/src/main/kotlin/org/fossify/voicerecorder/services/RecorderService.kt +++ b/app/src/main/kotlin/org/fossify/voicerecorder/services/RecorderService.kt @@ -267,45 +267,30 @@ class RecorderService : Service() { } private fun showNotification(): Notification { - val hideNotification = config.hideNotification val channelId = "simple_recorder" val label = getString(R.string.app_name) val notificationManager = getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager - val importance = if (hideNotification) { - NotificationManager.IMPORTANCE_MIN - } else { - NotificationManager.IMPORTANCE_DEFAULT - } - NotificationChannel(channelId, label, importance).apply { + NotificationChannel(channelId, label, NotificationManager.IMPORTANCE_DEFAULT).apply { setSound(null, null) notificationManager.createNotificationChannel(this) } - var priority = NotificationManager.IMPORTANCE_DEFAULT - var icon = R.drawable.ic_graphic_eq_vector - var title = label - var visibility = NotificationCompat.VISIBILITY_PUBLIC + val icon = R.drawable.ic_graphic_eq_vector + val title = label + val visibility = NotificationCompat.VISIBILITY_PUBLIC var text = getString(R.string.recording) if (status == RECORDING_PAUSED) { text += " (${getString(R.string.paused)})" } - if (hideNotification) { - priority = NotificationManager.IMPORTANCE_MIN - icon = R.drawable.ic_empty - title = "" - text = "" - visibility = NotificationCompat.VISIBILITY_SECRET - } - val builder = NotificationCompat.Builder(this, channelId) .setContentTitle(title) .setContentText(text) .setSmallIcon(icon) .setContentIntent(getOpenAppIntent()) - .setPriority(priority) + .setPriority(NotificationManager.IMPORTANCE_DEFAULT) .setVisibility(visibility) .setSound(null) .setOngoing(true) diff --git a/app/src/main/res/layout/activity_settings.xml b/app/src/main/res/layout/activity_settings.xml index 28ba2f5d..2f58e72e 100644 --- a/app/src/main/res/layout/activity_settings.xml +++ b/app/src/main/res/layout/activity_settings.xml @@ -148,21 +148,6 @@ - - - - - - diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 2b820ea4..96411a8b 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -22,7 +22,6 @@ %d recordings - Try hiding the recording notification Save recordings in Audio source Bitrate