Skip to content

fix: fallback to nearest bitrate when switching formats #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Jun 10, 2025
Merged

fix: fallback to nearest bitrate when switching formats #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/src/main/kotlin/org/fossify/voicerecorder/activities/SettingsActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ import org.fossify.voicerecorder.helpers.SAMPLING_RATE_BITRATE_LIMITS
import org.fossify.voicerecorder.models.Events
import org.greenrobot.eventbus.EventBus
import java.util.Locale
import kotlin.math.abs
import kotlin.system.exitProcess

class SettingsActivity : SimpleActivity() {
Expand Down Expand Up @@ -226,7 +227,11 @@ class SettingsActivity : SimpleActivity() {
private fun adjustBitrate() {
val availableBitrates = BITRATES[config.extension]!!
if (!availableBitrates.contains(config.bitrate)) {
config.bitrate = DEFAULT_BITRATE
val currentBitrate = config.bitrate
val closestBitrate = availableBitrates.minByOrNull { abs(it - currentBitrate) }
?: DEFAULT_BITRATE

config.bitrate = closestBitrate
binding.settingsBitrate.text = getBitrateText(config.bitrate)
}
}
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/kotlin/org/fossify/voicerecorder/helpers/Constants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@file:Suppress("MagicNumber")

package org.fossify.voicerecorder.helpers

const val REPOSITORY_NAME = "Voice-Recorder"
Expand Down
Loading