More friendly access to data/obb folder on Android 14+ - Version 2

[papjul]

What is it?

• Bugfix
• Feature
• Codebase improvement

Description of the changes in your PR

• On Android 14+, there is no longer any workaround to access data and obb folder. This PR ensures users of Android 14+ are no longer prompted into using the workaround that no longer works.
• It also includes the ability to add a "Open in system app" option when relevant. By default, this option is off to avoid any side effect given how intensively it is used across all Fossify apps.

Before/After Screenshots/Screen Record

• Before:

• After:
  On Android < 14:

On Android 14+:

Fixes the following issue(s)

• First step of Allow accessing /Android/data and /Android/obb with root File-Manager#16. Built on top of existing UI dialog
• A different UI was suggested in Allow accessing /Android/data and /Android/obb with root File-Manager#16, and it will be implemented in a separate PR as discussed in More friendly access to data/obb folder on Android 14+ #89

Relies on the following changes

• Open data/obb folder in system app on Android 14+ File-Manager#152 depends on this PR

Acknowledgement

• I read the contribution guidelines.

[naveensingh]

Hey, I did some quick testing, left some comments below. I'll review once again later.

Thanks for contributing!

[naveensingh]

Unrelated to your PR but it doesn't seem right to fire "Storage permission is required" toast when pressing back on the system SAF page.

[papjul]

Unrelated to your PR but it doesn't seem right to fire "Storage permission is required" toast when pressing back on the system SAF page.

If you're talking about the no_storage_permissions string, I don’t see it used in the Commons project, and I’m not sure to understand how you trigger this

[naveensingh]

Let's apply this new behavior to Android 11 and above. More context: FossifyOrg/File-Manager#16 (comment)

[papjul]

Done. The isRestrictedSAFOnlyRoot(path) already checks if running Android 11+.
I made a separate commit, so you can easily revert once you find out which DocumentUI versions are compatible on Android 11-13.

[naveensingh]

This change looks safe for the most part, even though the SAF callback is never executed now. These functions really are used extensively.

I hope you have tested this and it is regression-free ;)

[papjul]

This change looks safe for the most part, even though the SAF callback is never executed now. These functions really are used extensively.

I hope you have tested this and it is regression-free ;)

Well, I did my share of tests, and I hardly see how it could be worse than the current broken situation given the limited scope of the changes (that's also why I wanted to avoid any major UI changes).

Note that on my side, the file browsing feature is completely broken in apps other than the file manager (I know there is an ongoing issue about this), but the data/ and obb/ are still available (and the only available folders actually), so I could test the dialog on the Voice recorder app.

Then, you're the code reviewer, and you know your apps better than me, so your own tests are essential ;) And I noticed you already spotted a few existing bugs from before this PR ;)

[naveensingh]

Looks good now, thanks!

A Jitpack build should be up soon for FossifyOrg/File-Manager#152.