Merge pull request #13 from FoundatioFx/feature/result-improvements

Refactor Result classes to use immutable pattern and rename Ok to Success

Author: pwelter34

samples/ModularMonolithSample/src/Orders.Module/Extensions/ResultExtensions.cs

@@ -9,7 +9,7 @@ public static Microsoft.AspNetCore.Http.IResult ToHttpResult(this Result result)
     {
         return result.Status switch
         {
-            ResultStatus.Ok => Results.NoContent(),
+            ResultStatus.Success => Results.NoContent(),
             ResultStatus.NoContent => Results.NoContent(),
             ResultStatus.NotFound => Results.NotFound(new { message = result.Message }),
             ResultStatus.Invalid => Results.BadRequest(new { message = result.Message, errors = result.ValidationErrors }),
@@ -25,7 +25,7 @@ public static Microsoft.AspNetCore.Http.IResult ToHttpResult<T>(this Result<T> r
     {
         return result.Status switch
         {
-            ResultStatus.Ok => Results.Ok(result.Value),
+            ResultStatus.Success => Results.Ok(result.Value),
             ResultStatus.Created => Results.Ok(result.Value),
             ResultStatus.NotFound => Results.NotFound(new { message = result.Message }),
             ResultStatus.Invalid => Results.BadRequest(new { message = result.Message, errors = result.ValidationErrors }),
@@ -41,7 +41,7 @@ public static Microsoft.AspNetCore.Http.IResult ToCreatedResult<T>(this Result<T
     {
         return result.Status switch
         {
-            ResultStatus.Ok => Results.Created(location, result.Value),
+            ResultStatus.Success => Results.Created(location, result.Value),
             ResultStatus.Created => Results.Created(location, result.Value),
             ResultStatus.NotFound => Results.NotFound(new { message = result.Message }),
             ResultStatus.Invalid => Results.BadRequest(new { message = result.Message, errors = result.ValidationErrors }),

src/Foundatio.Mediator.Abstractions/Foundatio.Mediator.Abstractions.csproj

@@ -1,5 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <Import Project="..\..\build\common.props" />
+  <PropertyGroup>
+    <RootNamespace>Foundatio.Mediator</RootNamespace>
+  </PropertyGroup>
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.0" />

src/Foundatio.Mediator.Abstractions/IResult.cs

@@ -15,11 +15,6 @@ public interface IResult
     /// </summary>
     bool IsSuccess { get; }
 
-    /// <summary>
-    /// Gets the type of the result value.
-    /// </summary>
-    Type ValueType { get; }
-
     /// <summary>
     /// Gets the result value as an object.
     /// </summary>

src/Foundatio.Mediator.Abstractions/IsExternalInit.cs

@@ -0,0 +1,6 @@
+using System.ComponentModel;
+
+namespace System.Runtime.CompilerServices;
+
+[EditorBrowsable(EditorBrowsableState.Never)]
+internal static class IsExternalInit;