refactor: replace file-level #pragma warning disable 4014 with explicit discards

Use the discard operator (_ =) for intentionally unawaited Redis transaction-queued operations and a test fire-and-forget call, allowing the compiler to catch any future accidental unawaited async calls.

Author: niemyjski

src/Foundatio.Redis/Queues/RedisQueue.cs

@@ -12,7 +12,6 @@
 using Foundatio.Redis.Utility;
 using Microsoft.Extensions.Logging;
 using StackExchange.Redis;
-#pragma warning disable 4014
 
 namespace Foundatio.Queues;
 
@@ -504,9 +503,10 @@ await _resiliencePolicy.ExecuteAsync(async _ => await Task.WhenAll(
 
             var tx = Database.CreateTransaction();
             tx.AddCondition(Condition.KeyExists(GetRenewedTimeKey(entry.Id)));
-            tx.ListRemoveAsync(_workListName, entry.Id);
-            tx.ListLeftPushAsync(_waitListName, entry.Id);
-            tx.KeyDeleteAsync(GetRenewedTimeKey(entry.Id));
+            // Transaction-queued: commands execute atomically with ExecuteAsync(); individual results are not needed.
+            _ = tx.ListRemoveAsync(_workListName, entry.Id);
+            _ = tx.ListLeftPushAsync(_waitListName, entry.Id);
+            _ = tx.KeyDeleteAsync(GetRenewedTimeKey(entry.Id));
             bool success = await _resiliencePolicy.ExecuteAsync(async _ => await tx.ExecuteAsync()).AnyContext();
             if (!success)
                 throw new QueueException("Queue entry not in work list, it may have been auto abandoned.");
@@ -521,9 +521,10 @@ await _resiliencePolicy.ExecuteAsync(async _ => await Task.WhenAll(
 
             var tx = Database.CreateTransaction();
             tx.AddCondition(Condition.KeyExists(GetRenewedTimeKey(entry.Id)));
-            tx.ListRemoveAsync(_workListName, entry.Id);
-            tx.ListLeftPushAsync(_queueListName, entry.Id);
-            tx.KeyDeleteAsync(GetRenewedTimeKey(entry.Id));
+            // Transaction-queued: commands execute atomically with ExecuteAsync(); individual results are not needed.
+            _ = tx.ListRemoveAsync(_workListName, entry.Id);
+            _ = tx.ListLeftPushAsync(_queueListName, entry.Id);
+            _ = tx.KeyDeleteAsync(GetRenewedTimeKey(entry.Id));
             bool success = await _resiliencePolicy.ExecuteAsync(async _ => await tx.ExecuteAsync()).AnyContext();
             if (!success)
                 throw new QueueException("Queue entry not in work list, it may have been auto abandoned.");
@@ -548,10 +549,11 @@ private async Task DeadLetterMessageAsync(IQueueEntry<T> entry, int? attempts =
 
         var tx = Database.CreateTransaction();
         tx.AddCondition(Condition.KeyExists(GetRenewedTimeKey(entry.Id)));
-        tx.ListRemoveAsync(_workListName, entry.Id);
-        tx.ListLeftPushAsync(_deadListName, entry.Id);
-        tx.KeyDeleteAsync(GetRenewedTimeKey(entry.Id));
-        tx.KeyExpireAsync(GetPayloadKey(entry.Id), _options.DeadLetterTimeToLive);
+        // Transaction-queued: commands execute atomically with ExecuteAsync(); individual results are not needed.
+        _ = tx.ListRemoveAsync(_workListName, entry.Id);
+        _ = tx.ListLeftPushAsync(_deadListName, entry.Id);
+        _ = tx.KeyDeleteAsync(GetRenewedTimeKey(entry.Id));
+        _ = tx.KeyExpireAsync(GetPayloadKey(entry.Id), _options.DeadLetterTimeToLive);
         bool success = await _resiliencePolicy.ExecuteAsync(async _ => await tx.ExecuteAsync()).AnyContext();
         if (!success)
             throw new QueueException("Queue entry not in work list, it may have been auto abandoned.");
@@ -724,9 +726,10 @@ public async Task DoMaintenanceWorkAsync()
                 _logger.LogDebug("{WaitId}: Adding item back to queue for retry", waitId);
 
                 var tx = Database.CreateTransaction();
-                tx.ListRemoveAsync(_waitListName, waitId);
-                tx.ListLeftPushAsync(_queueListName, waitId);
-                tx.KeyDeleteAsync(GetWaitTimeKey(waitId.ToString()));
+                // Transaction-queued: commands execute atomically with ExecuteAsync(); individual results are not needed.
+                _ = tx.ListRemoveAsync(_waitListName, waitId);
+                _ = tx.ListLeftPushAsync(_queueListName, waitId);
+                _ = tx.KeyDeleteAsync(GetWaitTimeKey(waitId.ToString()));
                 bool success = await _resiliencePolicy.ExecuteAsync(async _ => await tx.ExecuteAsync()).AnyContext();
                 if (!success)
                     throw new Exception("Unable to move item to queue list.");

tests/Foundatio.Redis.Tests/Queues/RedisQueueTests.cs

@@ -20,8 +20,6 @@
 using StackExchange.Redis;
 using Xunit;
 
-#pragma warning disable 4014
-
 namespace Foundatio.Redis.Tests.Queues;
 
 public class RedisQueueTests : QueueTestBase, IAsyncLifetime
@@ -594,8 +592,8 @@ public virtual async Task DatabaseTimeoutDuringDequeueHandledCorrectly()
 local now = tonumber(redis.call(""time"")[1]);
 while ((((tonumber(redis.call(""time"")[1]) - now))) < {DELAY_TIME_SEC}) do end";
 
-        // db will be busy for DELAY_TIME_SEC which will cause timeout on the dequeue to follow
-        database.ScriptEvaluateAsync(databaseDelayScript);
+        // Fire-and-forget: intentionally blocks Redis server-side to simulate timeout; result is not needed.
+        _ = database.ScriptEvaluateAsync(databaseDelayScript);
 
         var completion = new TaskCompletionSource<bool>();
         await queue.StartWorkingAsync(async (item) =>