Replace deprecated RPOPLPUSH with LMOVE and add compatibility notes

- Replace RPOPLPUSH with LMOVE (Redis 6.2+) in DequeueId.lua since RPOPLPUSH is deprecated and may be removed in a future Redis version

- Add NOTE to RemoveIfEqual.lua and ReplaceIfEqual.lua about replacing with native CAS/CAD commands (SET IFEQ / DEL IFEQ) when Redis 8.4+ becomes the minimum supported version

- Add NOTE to Dispose() methods in RedisCacheClient, RedisFileStorage, and RedisQueue about implementing IAsyncDisposable when Foundatio base interfaces add support

- Update StackExchange.Redis to 2.13.1 for RESP3 default on AMR

Author: niemyjski

build/common.props

@@ -38,7 +38,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.203" PrivateAssets="All"/>
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.300" PrivateAssets="All"/>
     <PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" />
     <PackageReference Include="MinVer" Version="7.0.0" PrivateAssets="All" />
   </ItemGroup>

samples/Foundatio.SampleJob/Foundatio.SampleJob.csproj

@@ -10,6 +10,6 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Exceptionless.RandomData" Version="2.0.1" />
-    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="10.0.7" />
+    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="10.0.8" />
   </ItemGroup>
 </Project>

src/Foundatio.Redis/Cache/RedisCacheClient.cs

@@ -1010,6 +1010,8 @@ private void ConnectionMultiplexerOnConnectionFailed(object? sender, ConnectionF
         _logger.LogWarning("Redis connection failed: {FailureType}", connectionFailedEventArgs.FailureType);
     }
 
+    // NOTE: Implement IAsyncDisposable when Foundatio's ICacheClient interface adds support for it.
+    // IConnectionMultiplexer supports IAsyncDisposable since SE.Redis 2.6.66.
     public void Dispose()
     {
         if (_isDisposed)

src/Foundatio.Redis/Foundatio.Redis.csproj

@@ -4,7 +4,7 @@
     <PackageReference Include="Foundatio" Version="13.0.1" Condition="'$(ReferenceFoundatioSource)' == '' OR '$(ReferenceFoundatioSource)' == 'false'" />
     <ProjectReference Include="..\..\..\Foundatio\src\Foundatio\Foundatio.csproj" Condition="'$(ReferenceFoundatioSource)' == 'true'" />
 
-    <PackageReference Include="StackExchange.Redis" Version="2.12.14" />
+    <PackageReference Include="StackExchange.Redis" Version="2.13.1" />
   </ItemGroup>
   <ItemGroup>
     <EmbeddedResource Include="Scripts\*.lua" />

src/Foundatio.Redis/Queues/RedisQueue.cs

@@ -805,6 +805,8 @@ private LoadedLuaScript GetScript(LoadedLuaScript? script)
         return script ?? throw new QueueException("Lua scripts not loaded. Call LoadScriptsAsync first.");
     }
 
+    // NOTE: Implement IAsyncDisposable when Foundatio's IQueue interface adds support for it.
+    // IConnectionMultiplexer supports IAsyncDisposable since SE.Redis 2.6.66.
     public override void Dispose()
     {
         base.Dispose();

src/Foundatio.Redis/Scripts/DequeueId.lua

@@ -1,4 +1,4 @@
-local item = redis.call('RPOPLPUSH', @queueListName, @workListName);
+local item = redis.call('LMOVE', @queueListName, @workListName, 'RIGHT', 'LEFT');
 if item then
     local dequeuedTimeKey = @listPrefix .. ':' .. item .. ':dequeued';
     local renewedTimeKey = @listPrefix .. ':' .. item .. ':renewed';

src/Foundatio.Redis/Scripts/RemoveIfEqual.lua

@@ -1,4 +1,6 @@
-if redis.call('get', @key) == @expected then
+-- NOTE: When Redis 8.4+ becomes the minimum supported version, this script can be replaced
+-- with native CAS/CAD: DEL @key IFEQ @expected (SE.Redis 2.10.1+ supports this via ValueCondition).
+if redis.call('get', @key) == @expected then
   return redis.call('del', @key)
 else
   return 0

src/Foundatio.Redis/Scripts/ReplaceIfEqual.lua

@@ -1,4 +1,6 @@
-local currentVal = redis.call('get', @key)
+-- NOTE: When Redis 8.4+ becomes the minimum supported version, this script can be replaced
+-- with native CAS/CAD: SET @key @value IFEQ @expected [PX @expires] (SE.Redis 2.10.1+ supports this via ValueCondition).
+local currentVal = redis.call('get', @key)
 if (currentVal == false or currentVal == @expected) then
   if (@expires ~= nil and @expires ~= '') then
     return redis.call('set', @key, @value, 'PX', @expires) and 1 or 0

src/Foundatio.Redis/Storage/RedisFileStorage.cs

@@ -47,6 +47,8 @@ public RedisFileStorage(Builder<RedisFileStorageOptionsBuilder, RedisFileStorage
     ISerializer IHaveSerializer.Serializer => _serializer;
     public IDatabase Database => _connectionMultiplexer.GetDatabase();
 
+    // NOTE: Implement IAsyncDisposable when Foundatio's IFileStorage interface adds support for it.
+    // IConnectionMultiplexer supports IAsyncDisposable since SE.Redis 2.6.66.
     public void Dispose()
     {
         _connectionMultiplexer.ConnectionRestored -= ConnectionMultiplexerOnConnectionRestored;