refactor: update method names in RedisJobQueueTests for clarity and consistency

niemyjski · niemyjski · commit 4610e3735db3 · 2026-05-08T14:59:37.000-05:00
diff --git a/samples/Foundatio.SampleJob/PingQueueJob.cs b/samples/Foundatio.SampleJob/PingQueueJob.cs
@@ -28,7 +28,7 @@ public PingQueueJob(IQueue<PingRequest> queue, ICacheClient cacheClient, IMessag
 
     protected override Task<ILock?> GetQueueEntryLockAsync(IQueueEntry<PingRequest> queueEntry, CancellationToken cancellationToken = new CancellationToken())
     {
-        return _locker.AcquireAsync(String.Concat("pull:", queueEntry.Value!.Id),
+        return _locker.TryAcquireAsync(String.Concat("pull:", queueEntry.Value.Id),
             TimeSpan.FromMinutes(30),
             TimeSpan.FromSeconds(1));
     }
diff --git a/tests/Foundatio.Redis.Tests/Foundatio.Redis.Tests.csproj b/tests/Foundatio.Redis.Tests/Foundatio.Redis.Tests.csproj
@@ -3,10 +3,10 @@
     <OutputType>Exe</OutputType>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.4.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
     <PackageReference Include="xunit.v3.mtp-v2" Version="3.2.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" />
-    <PackageReference Include="GitHubActionsTestLogger" Version="3.0.3" PrivateAssets="All" />
+    <PackageReference Include="GitHubActionsTestLogger" Version="3.0.4" PrivateAssets="All" />
 
     <PackageReference Include="Foundatio.TestHarness" Version="13.0.0" Condition="'$(ReferenceFoundatioSource)' == '' OR '$(ReferenceFoundatioSource)' == 'false'" />
     <ProjectReference Include="..\..\..\Foundatio\src\Foundatio.TestHarness\Foundatio.TestHarness.csproj" Condition="'$(ReferenceFoundatioSource)' == 'true'" />
diff --git a/tests/Foundatio.Redis.Tests/Jobs/RedisJobQueueTests.cs b/tests/Foundatio.Redis.Tests/Jobs/RedisJobQueueTests.cs
@@ -32,15 +32,15 @@ protected override IQueue<SampleQueueWorkItem> GetSampleWorkItemQueue(int retrie
     }
 
     [Fact]
-    public override Task CanRunMultipleQueueJobsAsync()
+    public override Task ActivityWillFlowThroughQueueJobAsync()
     {
-        return base.CanRunMultipleQueueJobsAsync();
+        return base.ActivityWillFlowThroughQueueJobAsync();
     }
 
     [Fact]
-    public override Task CanRunQueueJobWithLockFailAsync()
+    public override Task CanRunMultipleQueueJobsAsync()
     {
-        return base.CanRunQueueJobWithLockFailAsync();
+        return base.CanRunMultipleQueueJobsAsync();
     }
 
     [Fact]
@@ -50,9 +50,15 @@ public override Task CanRunQueueJobAsync()
     }
 
     [Fact]
-    public override Task ActivityWillFlowThroughQueueJobAsync()
+    public override Task CanRunQueueJobWithLockFailAsync()
     {
-        return base.ActivityWillFlowThroughQueueJobAsync();
+        return base.CanRunQueueJobWithLockFailAsync();
+    }
+
+    [Fact]
+    public override Task GetQueueEntryLockAsync_WhenLockThrows_AbandonsQueueEntry()
+    {
+        return base.GetQueueEntryLockAsync_WhenLockThrows_AbandonsQueueEntry();
     }
 
     public override async ValueTask InitializeAsync()

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public PingQueueJob(IQueue<PingRequest> queue, ICacheClient cacheClient, IMessag`
`28`	`28`
`29`	`29`	`protected override Task<ILock?> GetQueueEntryLockAsync(IQueueEntry<PingRequest> queueEntry, CancellationToken cancellationToken = new CancellationToken())`
`30`	`30`	`{`
`31`		`- return _locker.AcquireAsync(String.Concat("pull:", queueEntry.Value!.Id),`
	`31`	`+ return _locker.TryAcquireAsync(String.Concat("pull:", queueEntry.Value.Id),`
`32`	`32`	`TimeSpan.FromMinutes(30),`
`33`	`33`	`TimeSpan.FromSeconds(1));`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,15 +32,15 @@ protected override IQueue<SampleQueueWorkItem> GetSampleWorkItemQueue(int retrie`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`[Fact]`
`35`		`- public override Task CanRunMultipleQueueJobsAsync()`
	`35`	`+ public override Task ActivityWillFlowThroughQueueJobAsync()`
`36`	`36`	`{`
`37`		`- return base.CanRunMultipleQueueJobsAsync();`
	`37`	`+ return base.ActivityWillFlowThroughQueueJobAsync();`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`[Fact]`
`41`		`- public override Task CanRunQueueJobWithLockFailAsync()`
	`41`	`+ public override Task CanRunMultipleQueueJobsAsync()`
`42`	`42`	`{`
`43`		`- return base.CanRunQueueJobWithLockFailAsync();`
	`43`	`+ return base.CanRunMultipleQueueJobsAsync();`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`[Fact]`
`@@ -50,9 +50,15 @@ public override Task CanRunQueueJobAsync()`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`[Fact]`
`53`		`- public override Task ActivityWillFlowThroughQueueJobAsync()`
	`53`	`+ public override Task CanRunQueueJobWithLockFailAsync()`
`54`	`54`	`{`
`55`		`- return base.ActivityWillFlowThroughQueueJobAsync();`
	`55`	`+ return base.CanRunQueueJobWithLockFailAsync();`
	`56`	`+ }`
	`57`	`+`
	`58`	`+ [Fact]`
	`59`	`+ public override Task GetQueueEntryLockAsync_WhenLockThrows_AbandonsQueueEntry()`
	`60`	`+ {`
	`61`	`+ return base.GetQueueEntryLockAsync_WhenLockThrows_AbandonsQueueEntry();`
`56`	`62`	`}`
`57`	`63`
`58`	`64`	`public override async ValueTask InitializeAsync()`