Updating simdjson to 4.2.2#103
Merged
FourierTransformer merged 6 commits intoDec 16, 2025
Merged
Conversation
Owner
|
It looks like it doesn't actually build with |
Contributor
Author
|
🤦 That it didn't compile, I am sure that I tested it before pushing up. Sorry for wasting your time. I've bumped the upstream version to 4.0.7, too. The code has been formatted. I'm not sure how you feel about that, but I'm happy to revert it as I realise that the format might not be for everyone as it's from an internal style guide. |
Contributor
Author
|
Hello, I've pushed another update to 4.2.2; this only updates the README and files from upstream. |
Owner
|
Looking good and thanks! Looks like some of the CI has become out of date, I have some time and can work on that! |
4dd7f45
into
FourierTransformer:master
12 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request bumps the version of simdjson from 3.12.3 to 4.2.2.
Due to some API changes with the introduction of 4.x, I've added handling and tests for
ondemand::json_type::unknown. At this point, it returns an error. I tried to follow existing conventions within the codebase for how to handle the error.The compiler was reporting that the following two lines were unused
I've removed them to stop the errors; however, I wanted to explicitly call this out because it may have other consequences that you are aware of. I am happy to return them if this change is a problem.
The files
src/simdjson.cppsrc/simdjson.hHave been directly copied (unmodified) from the releases page
singleheader.zip