keyring tests: duplicate checks removed, PascalCase for functions.

Author: derwesx

internal/keyring/keyring_test.go

@@ -7,7 +7,7 @@ import (
 	"testing"
 )
 
-func TestSaveandGetData(t *testing.T) {
+func TestSaveAndGetData(t *testing.T) {
 	keyring, err := SessionKeyring.CreateKeyring()
 	if err != nil {
 		t.Fatalf("failed getting keyring: %v", err)
@@ -27,7 +27,7 @@ func TestSaveandGetData(t *testing.T) {
 	}
 }
 
-func TestNokey(t *testing.T) {
+func TestNoKey(t *testing.T) {
 	keyring, err := SessionKeyring.CreateKeyring()
 	if err != nil {
 		t.Fatalf("failed getting keyring: %v", err)

internal/keyring/threadkeyring_test.go

@@ -12,7 +12,7 @@ var (
 	ctx = context.Background()
 )
 
-func TestSaveandGetDataThreaded(t *testing.T) {
+func TestSaveAndGetDataThreaded(t *testing.T) {
 	keyring, err := NewThreadKeyring(ctx, SessionKeyring)
 	if err != nil {
 		t.Fatalf("failed getting keyring: %v", err)
@@ -32,14 +32,11 @@ func TestSaveandGetDataThreaded(t *testing.T) {
 	}
 }
 
-func TestNokeyThreaded(t *testing.T) {
+func TestNoKeyThreaded(t *testing.T) {
 	keyring, err := NewThreadKeyring(ctx, SessionKeyring)
 	if err != nil {
 		t.Fatalf("failed getting keyring: %v", err)
 	}
-	if err != nil {
-		t.Fatalf("failed getting keyring: %v", err)
-	}
 	_, err = keyring.ReadKey("this.key.does.not.exist")
 	if !errors.Is(err, syscall.ENOKEY) {
 		t.Fatalf("err: %v", err)
@@ -51,9 +48,6 @@ func TestRemoveKeyThreaded(t *testing.T) {
 	if err != nil {
 		t.Fatalf("failed getting keyring: %v", err)
 	}
-	if err != nil {
-		t.Fatalf("failed getting keyring: %v", err)
-	}
 	b := []byte("test string")
 	if err := keyring.AddKey("test-2", b); err != nil {
 		t.Fatalf("err: %v", err)