Skip to content

Commit bcf8c5f

Browse files
authored
Merge pull request #580 from Fr-e-d/contrib/sync-1782343457
sync: update 2 file(s) in core/
2 parents 6c06381 + 8def7d7 commit bcf8c5f

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

.gaai/core/agents/sub-agents/qa.daemon-prompt.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ Execute these reads in order before any QA work:
6666
4. **`$GAAI_IMPL_REPORT_PATH`** — the implementation report from the Impl phase. This is the agent's narrative of what was done.
6767
5. **`git diff $GAAI_BASE_REF...HEAD` in `$GAAI_WORKTREE_PATH`** — run this as a Bash command. This is the ground-truth code diff. The IMPL report is a narrative; the diff is the GROUND TRUTH. QA validates that what the diff shows matches what the plan + ACs require. Discrepancy between IMPL narrative and diff = automatic FAIL with finding (model said X, code shows Y).
6868
6. **For EACH id in story frontmatter `related_decs`** — Read the file at `$GAAI_WORKTREE_PATH/.gaai/project/contexts/memory/decisions/{id}.md`. Verify code respects each decision's invariants. Run consistency-check per E94 D-12.
69+
- **Read the ENTIRE decision — not just the first determination heading.** Decisions evolve *in place*: a later amendment / reword / `` block **overrides** the original text above it, and the most recent in-section amendment is authoritative. Do NOT issue a verdict against a rule whose amendment block you stopped short of reading (a determination header immediately followed by an amendment is a classic trap — the header states the *old* rule). When checking a convention, confirm it against the current decision text rather than a remembered value; if the decision delegates the convention to a referenced guide (e.g. a voice/style guide), read that guide's current rule too.
6970

7071
---
7172

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
## [Unreleased]
1111

1212
### Changed
13+
- fix: instruct QA to read the ENTIRE decision incl. amendment/reword blocks
1314
- fix: anchor operator state + worktree base to the real checkout, not the home
1415
- fix: operator state (logs/locks) + worktree base anchor to REPO_ROOT, not the home
1516
- fix: stop auto-merge failure commit loop

0 commit comments

Comments
 (0)