Skip to content

Commit d887e20

Browse files
authored
windows: Hide background helpers behind CREATE_NO_WINDOW (zed-industries#41737)
Close zed-industries#41538 Release Notes: - Fixed some processes on windows not spawning with CREATE_NO_WINDOW --------- Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
1 parent d5421ba commit d887e20

4 files changed

Lines changed: 4 additions & 2 deletions

File tree

Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/auto_update/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ serde_json.workspace = true
2626
settings.workspace = true
2727
smol.workspace = true
2828
tempfile.workspace = true
29+
util.workspace = true
2930
workspace.workspace = true
3031

3132
[target.'cfg(not(target_os = "windows"))'.dependencies]

crates/auto_update/src/auto_update.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -962,7 +962,7 @@ pub async fn finalize_auto_update_on_quit() {
962962
.parent()
963963
.map(|p| p.join("tools").join("auto_update_helper.exe"))
964964
{
965-
let mut command = smol::process::Command::new(helper);
965+
let mut command = util::command::new_smol_command(helper);
966966
command.arg("--launch");
967967
command.arg("false");
968968
if let Ok(mut cmd) = command.spawn() {

crates/fs/src/fs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ impl Fs for RealFs {
377377

378378
#[cfg(windows)]
379379
if smol::fs::metadata(&target).await?.is_dir() {
380-
let status = smol::process::Command::new("cmd")
380+
let status = new_smol_command("cmd")
381381
.args(["/C", "mklink", "/J"])
382382
.args([path, target.as_path()])
383383
.status()

0 commit comments

Comments
 (0)