Fix Relion Star file import for ChimeraX 1.10.1#44
Closed
bwmr wants to merge 1 commit into
Closed
Conversation
Use pandas type to work with newer versions
Collaborator
|
Hi, thanks for the fix @bwmr and apologies for inactivity on this repo. The same issue exists for the Relion 5 variant. Unfortunately I can't edit this PR, so I'll raise one that fixes both instances of this deprecated call and credit it to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is the fix for the issue I describe in issue #43. The fix is implemented by updating the type checking function to use the newer pandas function, rather than numpy as before.
Best,
Benedikt