Skip to content

Commit b67fa05

Browse files
committed
removed bug in neighbour list output file allocation
1 parent 74566ef commit b67fa05

3 files changed

Lines changed: 11 additions & 9 deletions

File tree

POPSC/src/pops

-56 Bytes
Binary file not shown.

POPSC/src/putsasa.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,15 @@ static void print_atom_sasa(FILE *sasaOutFile, Arg *arg, Str *pdb, MolSasa *molS
109109
}
110110

111111
/* use original residue number of heteroresidues */
112+
/*
112113
if (pdb->atom[i].het) {
113114
atomName = &(pdb->atom[i].atomNameHet[0]);
114115
residueName = &(pdb->atom[i].residueNameHet[0]);
115116
} else {
117+
*/
116118
atomName = &(pdb->atom[i].atomName[0]);
117119
residueName = &(pdb->atom[i].residueName[0]);
118-
}
120+
/*}*/
119121

120122
/* for compatibility with POPSR Shiny, replace emtpy chain identifier */
121123
/* with '-' character */
@@ -450,7 +452,7 @@ void print_sasa(Arg *arg, Argpdb *argpdb, Str *pdb, Type *type, Topol *topol, \
450452
} else {
451453
rpopsOutFile = safe_open(rpopsOutFileName, "a");
452454
}
453-
print_neighbour_list(arg->neighbourOutFile, arg, pdb, topol);
455+
print_neighbour_list(rpopsOutFile, arg, pdb, topol);
454456
fclose(rpopsOutFile);
455457
} else {
456458
if (frame < 0) {

POPSR/inst/popsr/app.R

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,7 @@ ui <- fluidPage(
184184
),
185185
p("'Isolated Chains': SASA values of isolated chains. These values form the basis of the DeltaSASA data."),
186186
p("Only structures containing multiple chains will yield values for 'DeltaSASA' and 'Isolated Chains' tabs."),
187-
p("Results will be stored on the server until midnight GMT time and then automatically removed.
188-
Please use the 'Download ...' buttons under the tables to save your results in 'csv' format.
187+
p("Please use the 'Download ...' buttons under the tables to save your results in 'csv' format.
189188
The 'Download All Results' button on the side panel returns the zipped content of the entire output directory,
190189
i.e. all results produced for a given POPScomp job."
191190
),
@@ -231,16 +230,16 @@ ui <- fluidPage(
231230
h3("Help"),
232231
p("In case the server does not work as expected or server-related issues
233232
need clarification, please email the maintainers:
234-
Jens Kleinjung (jens@jkleinj.eu) and
235-
Franca Fraternali (franca.fraternali@kcl.ac.uk).
233+
Jens Kleinjung (jens@jkleinj.eu) and
234+
Franca Fraternali (franca.fraternali@ucl.ac.uk).
236235
For software and output errors, feature suggestions and similar topics,
237236
please add an entry to the ",
238237
a("Issues tab on the POPScomp GitHub page", href="https://github.com/Fraternalilab/POPScomp/issues"), "."
239238
)
240239
),
241240
tabPanel("About",
242241
h3("Shiny App"),
243-
p("This is version 3.4 of the POPScomp Shiny App."),
242+
p("This is version 3.8 of the POPScomp Shiny App."),
244243
p("For detailed information about the software visit Fraternali Lab's ",
245244
a("POPScomp GitHub repository", href="https://github.com/Fraternalilab/POPScomp"),
246245
"; the Wiki pages contain detailed installation and usage instructions."
@@ -291,8 +290,8 @@ ui <- fluidPage(
291290
GNU General Public License v3.0."
292291
),
293292
h4("Copyright Holders, Authors and Maintainers"),
294-
p("2002-2023 Franca Fraternali (author, maintainer)"),
295-
p("2008-2023 Jens Kleinjung (author, maintainer)"),
293+
p("2002-2026 Franca Fraternali (author, maintainer)"),
294+
p("2008-2026 Jens Kleinjung (author, maintainer)"),
296295
h4("Contributors"),
297296
p("2002 Kuang Lin and Valerie Hindie (translation to C)"),
298297
p("2002 Luigi Cavallo (parametrisation)")
@@ -440,6 +439,7 @@ server <- function(input, output) {
440439
"--rout --coarse --chainOut --residueOut --chainOut --neighbourOut",
441440
"--rProbe", input$rprobe, "--pdb", inputPDB, "1> POPScomp.o 2> POPScomp.e");
442441
}
442+
print(command)
443443
system_status = system(command, wait = TRUE)
444444

445445
## run POPScomp

0 commit comments

Comments
 (0)