Skip to content

[ + ] Typing Extensions#406

Closed
EdgarJRobles wants to merge 7 commits intoFreeCAD:masterfrom
EdgarJRobles:master
Closed

[ + ] Typing Extensions#406
EdgarJRobles wants to merge 7 commits intoFreeCAD:masterfrom
EdgarJRobles:master

Conversation

@EdgarJRobles
Copy link
Copy Markdown

Required for improve code reading .

@PhoneDroid
Copy link
Copy Markdown
Member

@EdgarJRobles

Please use the resolved package handle
( typing-extensions -> Check the PyPI page )

@PhoneDroid PhoneDroid changed the title Add typing_extensions for quetzal WB [ + ] Typing Extensions Aug 6, 2025
@chennes
Copy link
Copy Markdown
Member

chennes commented Aug 6, 2025

@EdgarJRobles thanks for the PR -- in addition to @PhoneDroid's comment, please keep the package list in alphabetical order. Thanks!

@EdgarJRobles
Copy link
Copy Markdown
Author

Thanks for clarify guys.
in code typing extensions must be type as import typing_extesion but to install from pip it must type as typing-extesion then package.xml should contain <depend optional="False" type="automatic">typing-extensions</depend>

then typing_extension is not required

@EdgarJRobles
Copy link
Copy Markdown
Author

reopen because EdgarJRobles/quetzal@06ce9d2 didn't work

i changed <depend optional="False" type="automatic">typing_extensions</depend> to
<depend optional="False" type="automatic">typing-extensions</depend> in package.xml still no auto install typing-extensions

is there something missing?

@EdgarJRobles EdgarJRobles reopened this Aug 8, 2025
@chennes
Copy link
Copy Markdown
Member

chennes commented Aug 8, 2025

Your PR here is still valid, and required, it just needs a bit of cleanup. You DO need to add typing-extensions to the list of Python packages that the Addon Manager is allowed to install, but you should add it to the list following the PEP 503 Normalization (e.g. "typing-extensions", not "typing_extensions"), and it should be added in alphabetical order.

Added in alphabetical order
@EdgarJRobles
Copy link
Copy Markdown
Author

the module was added 2 weeks ago
image
still not get it

@chennes
Copy link
Copy Markdown
Member

chennes commented Aug 24, 2025

I'll try to find a machine that doesn't have typing-extensions installed at the system level and give it a test run. Keep in mind that unless you are using the development branch of the Addon Manager, you will have to either update your addon, or uninstall and reinstall it, for the addon manager to pick up the new dependency.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2025

🤖 Constraints Bot: regenerated the constraints files and added a commit with the changes

@PhoneDroid
Copy link
Copy Markdown
Member

@EdgarJRobles The new index is Python 3.10+ only, so the typing module should
always be available, you shouldn't require the typing-extensions package right?

@PhoneDroid PhoneDroid self-assigned this Apr 3, 2026
@chennes chennes closed this May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 𝗣𝗮𝗰𝗸𝗮𝗴𝗲 In the context of a Python package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants