[1.0.0] Consolidate server queue writing to one spot (Part 1)#223
Merged
ChadSikorra merged 5 commits intoJul 18, 2026
Merged
Conversation
…nsolidated writes.
ChadSikorra
force-pushed
the
upgrade/generator-middleware-return-pt1
branch
from
July 18, 2026 15:46
c062bd6 to
9d381b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all the server handlers use the server queue directly to read / write responses as needed. This is messy and has duplicated logic and made things harder to do in one spot since it's not consolidated. This aims to move the logic into a middleware and have the handlers instead return a stream with a generator so we can pipe through the results in one spot. This way there's only one spot with logic writing to the queue and it simplifies logic in a bunch of spots.
Very messy since all the handlers and all the tests need to be touched to switch all the spots over unfortunately.