Fix composite assembly with FreeFem++-mpi#393
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts BEM bilinear form type detection in compositeFESpace.cpp to work reliably under FreeFem++-mpi by using a helper that safely handles missing runtime type registration.
Changes:
- Added
isBemFormBilinearType()helper that usesatype0<...>()for safe type lookups. - Replaced multiple direct
atype<const BemFormBilinear*>()comparisons with the new helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reported-by: Chris Douglas @cmdoug
prj-
force-pushed
the
jolivet/fix-composite
branch
from
May 8, 2026 13:31
7f44da6 to
845702b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.