Lower tolerance in BAMG to avoid misidentification of overlapping edges#397
Open
prj- wants to merge 1 commit into
Open
Lower tolerance in BAMG to avoid misidentification of overlapping edges#397prj- wants to merge 1 commit into
prj- wants to merge 1 commit into
Conversation
Contributor
|
Here is a test case. See the chevalier_etal_2024 example. |
Member
Author
On my end, this test case is failing with: But that's unrelated to BAMG (and the present PR), isn't it? |
Contributor
|
Sorry about that, tried to rush something to you. I am heading out on vacation for the next week, but will follow up later this month when I have time to look more closely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #319