Use PATH_MAX for $INCLUDE path resolution#133
Open
mykhailopopivniak wants to merge 1 commit into
Open
Conversation
rc_read_dictionary() resolved relative $INCLUDE paths into a fixed 64-byte buffer (AUTH_ID_LEN). Since AUTH_ID_LEN is sized for attribute names, not file paths, a parent directory longer than ~60 characters caused snprintf to silently truncate the joined path; the recursive fopen() then failed with a misleading "couldn't open dictionary" error. Size the buffer at PATH_MAX instead, and return an explicit error if the joined path would still exceed it rather than loading the wrong file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rc_read_dictionary() resolved relative $INCLUDE paths into a fixed 64-byte buffer (AUTH_ID_LEN). Since AUTH_ID_LEN is sized for attribute names, not file paths, a parent directory longer than ~60 characters caused snprintf to silently truncate the joined path; the recursive fopen() then failed with a misleading "couldn't open dictionary" error.
Size the buffer at PATH_MAX instead, and return an explicit error if the joined path would still exceed it rather than loading the wrong file.