rlm_cache_memcached: fix date deserialize#5819
Open
jimdigriz wants to merge 1 commit intoFreeRADIUS:v3.2.xfrom
Open
rlm_cache_memcached: fix date deserialize#5819jimdigriz wants to merge 1 commit intoFreeRADIUS:v3.2.xfrom
jimdigriz wants to merge 1 commit intoFreeRADIUS:v3.2.xfrom
Conversation
Contributor
Author
|
Looks like this also impacts |
dates are stored unquoted which trips map_afrom_attr_str so: &reply:Event-Timestamp := Apr 6 2026 13:59:50 UTC Turns into: &reply:Event-Timestamp := Apr Which then emits: (1) cache: &Cache-Expires = 1775484257 &Cache-Created = 1775484197 &reply:Reply-Message += 'Cache last updated at Mon Apr 6 14:03:17 2026' &reply:Class := 0x6838512f563977644f754e76436d56505167594d57513871673376544d2e5549 &reply:Event-Timestamp := Apr 6 2026 14:03:17 UTC (1) cache: ERROR: failed to parse time string "Apr" ----> request then fails Fix this by adding quoting around date, giving us: (1) cache: Retrieved 265 bytes from memcached (1) cache: &Cache-Expires = 1775484334 &Cache-Created = 1775484274 &reply:Reply-Message += 'Cache last updated at Mon Apr 6 14:04:34 2026' &reply:Class := 0x614c366d4c474f573536514c34737a67632e4b674f342e336645614530617a32 &reply:Event-Timestamp := 'Apr 6 2026 14:04:34 UTC' (1) cache: Found entry for "bob" (1) cache: Merging cache entry into request (1) cache: &reply:Reply-Message = "Cache last updated at Mon Apr 6 14:04:34 2026" (1) cache: &reply:Event-Timestamp = "Apr 6 2026 14:04:34 UTC" rlm_cache (cache): Released connection (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dates are stored unquoted which trips
map_afrom_attr_strso:Turns into:
Which then emits:
Fix this by adding quoting around date (the call to
map_afrom_attr_stralready says 'please quote'), giving us: