Profiling images can now be generated from crossbuild images#5834
Profiling images can now be generated from crossbuild images#5834marc-casavant wants to merge 2 commits intoFreeRADIUS:masterfrom
Conversation
| @echo " crossbuild.IMAGE.clean - stop container and tidy up" | ||
| @echo " crossbuild.IMAGE.wipe - remove Docker image" | ||
| @echo "" | ||
| @echo "Profiling targets:" |
There was a problem hiding this comment.
Not entirely convinced these should be in the help. They should be used by the CI jobs only, it's not helpful to have extra targets for developers that they should never use.
There was a problem hiding this comment.
As a minor point, help is useful. :) Especially if I want to run profiling tools locally.
As seen here, it's a bit of a pain to get the profiling builds up and running. It's a lot easier to do make profiling
So I'm OK with leaving this in.
There was a problem hiding this comment.
Agreed on the ones that developers use. But some of these targets are really only for CI, which might be confusing if a developer tries to use them. They're the ones I suggest not adding to help :)
As long as it's clear, then np.
There was a problem hiding this comment.
If the targets are only for CI, then there's no need to print them out in the help text.
There was a problem hiding this comment.
I kinda like having those in the help text :) Helps my brain, but I'm okay to remove the extra info in the help text is that's what we prefer.
There was a problem hiding this comment.
I believe the targets are useful for developers, especially when used with profiling multi-server tests.
21643c9 to
64edef6
Compare
34872f1 to
f8f3881
Compare
f8f3881 to
ff45c05
Compare
Key Changes:
FROM <CROSSBULD_IMAGE>Build Steps Example:
Generate the crossbuild Dockerfile.cb:
make crossbuild.ubuntu24.regenBuild the crossbuild base image:
make crossbuild.ubuntu24.buildGenerate the profiling Dockerfile.prof:
make crossbuild.ubuntu24.profile.regenBuild the profiling image:
make crossbuild.ubuntu24.profile.build