Skip to content

fuzzer: add radius_encode harness to be consumed by OSS-Fuzz#5862

Open
DavidKorczynski wants to merge 1 commit into
FreeRADIUS:masterfrom
DavidKorczynski:radius_encode
Open

fuzzer: add radius_encode harness to be consumed by OSS-Fuzz#5862
DavidKorczynski wants to merge 1 commit into
FreeRADIUS:masterfrom
DavidKorczynski:radius_encode

Conversation

@DavidKorczynski
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@alandekok
Copy link
Copy Markdown
Member

There is already an unused encode stub in fuzzer.c. That code also uses the common.c file, which makes the protocol-specific fuzzers much simpler.

Since the encode path requires protocol-specific information, and the fuzzer.c file is now tiny, it might be worth just making protocol-specific encoders for many things:

  • copy fuzzer.c to fuzzer_radius.c (which removes a lot of the boilerplate of fuzzer_radius_encode.c in this PR)
  • poke the build system to treat fuzzer_radius as a separate target, but which is still FUZZER_PROTOCOL
  • update fuzzer_radius to call the encode path as is done in this PR.

Once that's done, it should be fairly straightforward to do the same for the other protocols.

Signed-off-by: David Korczynski <david@adalogics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants