Fix race in POSIX port vPortEndScheduler#1262
Merged
rohitmadan07 merged 2 commits intoFreeRTOS:mainfrom Apr 3, 2025
Merged
Conversation
The `vPortEndScheduler` checks whether it's a FreeRTOS thread after signalling the scheduler thread to stop. This creates a race between the check and the destruction of the thread key. By moving the signal to the scheduler thread after the check, the race is prevented.
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
aggarg
approved these changes
Apr 3, 2025
|
kar-rahul-aws
approved these changes
Apr 3, 2025
|
Is there any chance to get a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi, after upgrading from V11.1.0 to V11.2.0, we saw the call to
vPortEndSchedulersometimes return when using the POSIX port. We are only callingvPortEndSchedulerfrom FreeRTOS tasks (threads in the POSIX port), so we don't expect the call to actually return.There seems to be a race between the check whether the thread calling
vPortEndScheduleris a FreeRTOS thread and the destruction of the thread key. If the thread key is destroyed before the check, the check fails even for FreeRTOS threads.Moving the check before the signal to end the scheduler should prevent the race.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.