Add cast in stack allocation for task creation#1340
Conversation
AhmedIsmail02
left a comment
AhmedIsmail02
left a comment
There was a problem hiding this comment.
This typecast was previously removed here. However, since pvPortMallocStack() may be provided by the application when configSTACK_ALLOCATION_FROM_SEPARATE_HEAP is set to 1, its return type is not fixed across all configurations. Adding the explicit cast restores consistency with existing kernel code and makes the intended pointer type explicit.
|
@sidharth-458 Could you please rebase your branch with the latest version of the main branch? This should fix the failing |
sidharth-458
force-pushed
the
add_cast_in_stack_allocation
branch
from
82187b5 to
e430418
Compare
|
@AhmedIsmail02 I have rebased my branch, is it ok now? |
|
@sidharth-458 LGTM, thank you for your contribution. |
for negative portSTACK_GROWTH, add cast to stack allocation, just like it is in positive portSTACK_GROWTH
jasonpcarroll
force-pushed
the
add_cast_in_stack_allocation
branch
from
e430418 to
d383eba
Compare
|
4 participants
Add cast in stack allocation for task creation
Description
for negative portSTACK_GROWTH, add cast to stack allocation, just like it is in positive portSTACK_GROWTH
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.