Remove ACL permissions for deleted resource#1420
Closed
kstribrnAmzn wants to merge 3 commits into
Closed
Conversation
Setting the configENABLE_ACL_OBJECT_DELETION_CLEANUP flag will revoke ACL permissions across all tasks. Previously the task deleting the object would need to also revoke permissions.
kstribrnAmzn
force-pushed
the
objectDeletionACLCleanup
branch
2 times, most recently
from
aa16f3a to
517d053
Compare
kstribrnAmzn
force-pushed
the
objectDeletionACLCleanup
branch
from
517d053 to
7a84a83
Compare
|
Member
Author
|
Discarding this until we have further requests for ACL cleanup upon object deletion with MPUv2 wrappers. I don't want to introduce this code as iterating over the task list will slow down the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setting the
configENABLE_ACL_OBJECT_DELETION_CLEANUPflag will revoke ACL permissions acrossall tasks. Previously the task deleting the object would need to also revoke permissions.
Test Steps
To be completed
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.