Skip to content

Fix incorrect state transition #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fr3ya wants to merge 3 commits into from
Closed

Fix incorrect state transition #1302

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac7ea71
Fix incorrect TCP state transition on connection timeout
Nov 21, 2025
ef44afe
Update unit tests and coverage based on maintainer feedback
Dec 5, 2025
ec496f1
Merge branch 'main' into fix/state-transition
jasonpcarroll Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/FreeRTOS_TCP_IP.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@
if( ( ( xPreviousState == eCONNECT_SYN ) ||
( xPreviousState == eSYN_FIRST ) ||
( xPreviousState == eSYN_RECEIVED ) ) &&
( eTCPState == eCLOSE_WAIT ) )
( ( eTCPState == eCLOSE_WAIT ) || ( eTCPState == eCLOSED ) ) )
{
/* A socket was in the connecting phase but something
* went wrong and it should be closed. */
Expand Down
4 changes: 2 additions & 2 deletions source/FreeRTOS_TCP_Transmission.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,11 @@
{
/* The connection is in the SYN status. The packet will be repeated
* to most 3 times. When there is no response, the socket get the
* status 'eCLOSE_WAIT'. */
* status 'eCLOSED'. */
FreeRTOS_debug_printf( ( "Connect: giving up %xip:%u\n",
( unsigned ) pxSocket->u.xTCP.xRemoteIP.ulIP_IPv4, /* IP address of remote machine. */
pxSocket->u.xTCP.usRemotePort ) ); /* Port on remote machine. */
vTCPStateChange( pxSocket, eCLOSE_WAIT );
vTCPStateChange( pxSocket, eCLOSED );
}
else if( prvTCPMakeSurePrepared( pxSocket ) == pdTRUE )
{
Expand Down
Loading