Improve ARP buffer allocation sizing and ICMPv6 NS validation ordering#1330
Merged
patrzhan merged 1 commit intoFreeRTOS:mainfrom Apr 13, 2026
Merged
Improve ARP buffer allocation sizing and ICMPv6 NS validation ordering#1330patrzhan merged 1 commit intoFreeRTOS:mainfrom
patrzhan merged 1 commit intoFreeRTOS:mainfrom
Conversation
77f00d8 to
b04d4ca
Compare
b04d4ca to
d16cd52
Compare
AniruddhaKanhere
approved these changes
Apr 10, 2026
archigup
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two improvements to buffer handling:
FreeRTOS_ARP.c: In
FreeRTOS_OutputARPRequest_Multi(), the buffer allocation now usesFreeRTOS_max_size_t()to request the larger ofsizeof(ARPPacket_t)andipconfigETHERNET_MINIMUM_PACKET_BYTES, ensuring the allocated buffer is always large enough for the subsequent padding loop.FreeRTOS_ND.c: In the Neighbor Solicitation case of
prvProcessICMPMessage_IPv6(), the buffer size validation is reordered to occur before accessing thexIPv6Addressfield.Test Steps
BufferAllocation_1andBufferAllocation_2.Checklist:
Related Issue
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.