Skip to content

Suppress MISRA 14.3 finding in ARP buffer allocation #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrzhan merged 1 commit into from
Apr 17, 2026
+6 −0
Merged

Suppress MISRA 14.3 finding in ARP buffer allocation #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions MISRA.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,9 @@ _Ref 14.3.1_

- MISRA C-2012 Rule 14.3 False positive as the value might be changed depending
on the conditionally compiled code
- MISRA C-2012 Rule 14.3 The controlling expression compares sizeof against a
configuration constant. The result is invariant for a given configuration but
varies across different user configurations.

#### Rule 17.2

Expand Down
3 changes: 3 additions & 0 deletions source/FreeRTOS_ARP.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,6 +1194,9 @@
{
/* This is called from the context of the IP event task, so a block time
* must not be used. */
/* MISRA Ref 14.3.1 [Invariant controlling expression] */
/* More details at: https://github.com/FreeRTOS/FreeRTOS-Plus-TCP/blob/main/MISRA.md#rule-143 */
/* coverity[misra_c_2012_rule_14_3_violation] */
pxNetworkBuffer = pxGetNetworkBufferWithDescriptor( ( ( sizeof( ARPPacket_t ) > ( size_t ) ipconfigETHERNET_MINIMUM_PACKET_BYTES ) ? sizeof( ARPPacket_t ) : ( size_t ) ipconfigETHERNET_MINIMUM_PACKET_BYTES ), ( TickType_t ) 0U );

if( pxNetworkBuffer != NULL )
Expand Down
Loading