Skip to content

Fix: Hide 'Minimize to system tray' setting on Wayland#9208

Merged
FreeTubeBot merged 11 commits into
FreeTubeApp:developmentfrom
Shadorc:feat/tray-tooltip
Jun 28, 2026
Merged

Fix: Hide 'Minimize to system tray' setting on Wayland#9208
FreeTubeBot merged 11 commits into
FreeTubeApp:developmentfrom
Shadorc:feat/tray-tooltip

Conversation

@Shadorc

@Shadorc Shadorc commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #9187

Description

Wayland does not have a 'minimize' event (see electron/electron#51766 (comment)).
FreeTube can't really do anything on its side, nor can Electron.
Similar to MacOS, the fix is to hide this setting if Wayland is detected.

Testing

Linux Wayland

  1. Execute FreeTube on Linux Wayland
  2. Check that 'Minimize to tray' setting is hidden

Linux Wayland with compatibility mode

  1. Execute FreeTube on Linux Wayland with --ozone-platform=x11
  2. Check that 'Minimize to tray' setting is visible and working as intended

Windows

  1. Execute FreeTube on Windows
  2. Check that 'Minimize to tray' setting is visible and working as intended

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 29, 2026 08:46
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 29, 2026
auto-merge was automatically disabled May 29, 2026 09:18

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 29, 2026 09:18
@efb4f5ff-1298-471a-8973-3d47447115dc

efb4f5ff-1298-471a-8973-3d47447115dc commented May 29, 2026

Copy link
Copy Markdown
Member

im wondering if we could just hide the setting when wayland is detected

@Shadorc

Shadorc commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've spent some time searching to find out how to detect if we are using Wayland, but there doesn't seem to be a simple solution.
The standard approach is to rely on XDG_SESSION_TYPE, but as I mentioned in my issue, you can run Electron with --ozone-platform=x11 and it will work. This means we should also check for this argument.
There are people #9187 (comment) that use Wayland but seem to have their OS running FreeTube with X11 compatibility mode or something.
You can also use software like XWayland to run Wayland apps on an X11 server. It might change the XDG_SESSION_TYPE value correctly, but that seems like too many scenarios to implement something simple and reliable.

@Shadorc

Shadorc commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've tested with two electron-based apps that I use: Discord and Signal.
They have a different approach, they both consider that "Minimize to system tray" can only occur when a user presses the close button, removing the app from the taskbar, not when minimizing.
According to signalapp/Signal-Desktop#5840 (comment), it is the same behaviour for Battle.net

@absidue

absidue commented Jun 3, 2026

Copy link
Copy Markdown
Member

The setting in FreeTube is explicitly designed to be minimize to system tray, not close to system tray. As for detecting wayland you can use the same approach as the existing code: https://github.com/FreeTubeApp/FreeTube/blob/development/src/main/index.js#L1163.

@Shadorc

Shadorc commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

I apologize if I wasn't clear. I wasn't suggesting that FreeTube should mimic "close to system tray" behavior. I was simply providing examples of how other Electron apps handle the "Minimize to tray" setting. If any of those apps successfully minimized to the system tray like FreeTube does on X11, it could have indicated that a solution was possible.

Thanks for the code reference. As I mentioned in my concerns here, I wasn't sure it would cover all possible scenarios, but if you're confirming it does, that's great! I'll use it to hide the setting when it's unavailable.

auto-merge was automatically disabled June 3, 2026 16:05

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 3, 2026 16:05
@Shadorc Shadorc changed the title Feat: Add tooltip to 'Minimize to system tray' setting Fix: Hide 'Minimize to system tray' setting on Wayland Jun 3, 2026
auto-merge was automatically disabled June 3, 2026 16:10

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 3, 2026 16:10
absidue
absidue reviewed Jun 6, 2026
View reviewed changes
Comment thread src/main/index.js Outdated
@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jun 6, 2026
auto-merge was automatically disabled June 6, 2026 12:28

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 6, 2026 12:28
ChunkyProgrammer
ChunkyProgrammer reviewed Jun 7, 2026
View reviewed changes
Comment thread src/renderer/components/GeneralSettings/GeneralSettings.vue
auto-merge was automatically disabled June 8, 2026 17:54

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 8, 2026 17:54
auto-merge was automatically disabled June 8, 2026 17:59

Head branch was pushed to by a user without write access

@Shadorc Shadorc force-pushed the feat/tray-tooltip branch from 91523c2 to 256c4da Compare June 8, 2026 17:59
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 8, 2026 17:59
auto-merge was automatically disabled June 8, 2026 18:09

Head branch was pushed to by a user without write access

@Shadorc Shadorc force-pushed the feat/tray-tooltip branch from 256c4da to 5e262c7 Compare June 8, 2026 18:09
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 8, 2026 18:09
@Shadorc

Shadorc commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'm not sure what is happening with the CI, it builds on my side and yarn run lint-fix does not show any warning/error. It indicates "Module not found" for three different modules. I've rebased on development branch with no luck.

absidue
absidue reviewed Jun 8, 2026
View reviewed changes
Comment thread src/datastores/handlers/base.js Outdated
auto-merge was automatically disabled June 8, 2026 20:53

Head branch was pushed to by a user without write access

@Shadorc Shadorc force-pushed the feat/tray-tooltip branch from c6b6884 to a868995 Compare June 8, 2026 20:53
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 8, 2026 20:53
auto-merge was automatically disabled June 8, 2026 20:56

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 8, 2026 20:56
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested PR: stale labels Jun 27, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Jun 27, 2026
View reviewed changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on Fedora and Windows

Sorry for the wait.

PikachuEXE
PikachuEXE approved these changes Jun 28, 2026
View reviewed changes

@PikachuEXE PikachuEXE left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows

@FreeTubeBot FreeTubeBot merged commit 5ce9797 into FreeTubeApp:development Jun 28, 2026
6 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 28, 2026
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jun 28, 2026
@PikachuEXE
Merge branch 'development' into fix/auto-trailing-slash-removal
52ef677 
* development:
  Fix: Hide 'Minimize to system tray' setting on Wayland (FreeTubeApp#9208)
  Translated using Weblate (Hungarian)
  Fix: import history from youtube adding trailing space to title (FreeTubeApp#9204)
  Fix keyboard shortcuts arent't working during "SABR backoff" (FreeTubeApp#9315)
  Fix incomplete watch progresss bar if video length has milliseconds (FreeTubeApp#9267)
  Translated using Weblate (Hungarian)
  Fix default quality not working when video aspect ratio is not 16/9 or 9/16 (FreeTubeApp#9312)
  Remove error when 'publishedText' is missing as it is a valid state (FreeTubeApp#9321)
  Fix LibRedirect download link in README (FreeTubeApp#9323)
  Bump actions/cache/restore from 5.0.5 to 6.0.0 (FreeTubeApp#9329)
  Bump actions/cache/save from 5.0.5 to 6.0.0 (FreeTubeApp#9330)
  Translated using Weblate (French)
  Fix premierDate parsing in subscription (FreeTubeApp#9309)

# Conflicts:
#	src/renderer/components/GeneralSettings/GeneralSettings.vue
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jul 1, 2026
@PikachuEXE
Merge branch 'development' into update/youtubei.js
bc0c66e 
* development: (21 commits)
  Bump the webpack group across 1 directory with 2 updates (FreeTubeApp#9347)
  Bump the stylelint group across 1 directory with 3 updates (FreeTubeApp#9345)
  Bump vue from 3.5.38 to 3.5.39 (FreeTubeApp#9353)
  Bump js-yaml from 4.2.0 to 5.2.0 (FreeTubeApp#9348)
  Bump globals from 17.6.0 to 17.7.0 (FreeTubeApp#9350)
  Bump the fortawesome group with 5 updates (FreeTubeApp#9346)
  Bump shaka-player from 5.1.10 to 5.1.12 (FreeTubeApp#9351)
  Bump the eslint group with 6 updates (FreeTubeApp#9344)
  Translated using Weblate (Basque)
  Fix: Hide 'Minimize to system tray' setting on Wayland (FreeTubeApp#9208)
  Translated using Weblate (Hungarian)
  Fix: import history from youtube adding trailing space to title (FreeTubeApp#9204)
  Fix keyboard shortcuts arent't working during "SABR backoff" (FreeTubeApp#9315)
  Fix incomplete watch progresss bar if video length has milliseconds (FreeTubeApp#9267)
  Translated using Weblate (Hungarian)
  Fix default quality not working when video aspect ratio is not 16/9 or 9/16 (FreeTubeApp#9312)
  Remove error when 'publishedText' is missing as it is a valid state (FreeTubeApp#9321)
  Fix LibRedirect download link in README (FreeTubeApp#9323)
  Bump actions/cache/restore from 5.0.5 to 6.0.0 (FreeTubeApp#9329)
  Bump actions/cache/save from 5.0.5 to 6.0.0 (FreeTubeApp#9330)
  ...

# Conflicts:
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes
@absidue absidue absidue approved these changes
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes
@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: 'Minimize to Tray' does not work with Wayland

6 participants

@Shadorc @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @PikachuEXE @ChunkyProgrammer @FreeTubeBot