fix(libraries): prevent dangling reference in ely libs override (#61)

notwindstone · web-flow · commit 0cb897e09eb6 · 2025-04-13T10:54:08.000+03:00
diff --git a/launcher/minecraft/launch/ApplyLibraryOverrides.cpp b/launcher/minecraft/launch/ApplyLibraryOverrides.cpp
@@ -57,8 +57,8 @@ void ApplyLibraryOverrides::onLibraryOverrideDownloadFinished()
             continue;
         }
 
-        auto versionRef = artifactRef.toObject()[library->version()];
-        if (!versionRef.isObject()) {
+        auto version = artifactRef.toObject().value(library->version());
+        if (!version.isObject()) {
             continue;
         }
 
@@ -67,7 +67,7 @@ void ApplyLibraryOverrides::onLibraryOverrideDownloadFinished()
             continue;
         }
 
-        auto override = versionRef.toObject();
+        auto override = version.toObject();
         auto newDownloadInfo = std::make_shared<MojangDownloadInfo>();
         newDownloadInfo->url = override["url"].toString();
         newDownloadInfo->sha1 = override["sha1"].toString();

Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,8 @@ void ApplyLibraryOverrides::onLibraryOverrideDownloadFinished()`
`57`	`57`	`continue;`
`58`	`58`	`}`
`59`	`59`
`60`		`- auto versionRef = artifactRef.toObject()[library->version()];`
`61`		`- if (!versionRef.isObject()) {`
	`60`	`+ auto version = artifactRef.toObject().value(library->version());`
	`61`	`+ if (!version.isObject()) {`
`62`	`62`	`continue;`
`63`	`63`	`}`
`64`	`64`
`@@ -67,7 +67,7 @@ void ApplyLibraryOverrides::onLibraryOverrideDownloadFinished()`
`67`	`67`	`continue;`
`68`	`68`	`}`
`69`	`69`
`70`		`- auto override = versionRef.toObject();`
	`70`	`+ auto override = version.toObject();`
`71`	`71`	`auto newDownloadInfo = std::make_shared<MojangDownloadInfo>();`
`72`	`72`	`newDownloadInfo->url = override["url"].toString();`
`73`	`73`	`newDownloadInfo->sha1 = override["sha1"].toString();`