feat(OpenTelemetry/Transport): replace Guzzle with Symfony HTTP Client and Nyholm PSR-7/17 (#209)

* feat(OpenTelemetry/Transport): replace Guzzle with Symfony HTTP Client and Nyholm PSR-7/17

* feat(DependencyInjection): add support for configuring custom PSR-18 HTTP client

* refactor(DependencyInjection): rename `http_client` to `transport_http_client` for clarity in telemetry transport configuration

* docs(DependencyInjection): document required PSR interfaces for transport_http_client config

* feat(DependencyInjection): implement default PSR-18 client registration with support for custom configuration

* tests(Unit/DI): remove useless configuration test

Author: gaelreyrol

composer.json

@@ -22,9 +22,8 @@
     ],
     "require": {
         "php": ">=8.2",
-        "guzzlehttp/guzzle": "^7.10",
-        "guzzlehttp/psr7": "^2.9",
         "monolog/monolog": "^3.10",
+        "nyholm/psr7": "^1.8",
         "open-telemetry/api": "^1",
         "open-telemetry/context": "^1",
         "open-telemetry/opentelemetry-logger-monolog": "^1",
@@ -33,6 +32,8 @@
         "open-telemetry/sdk": "^1",
         "open-telemetry/sem-conv": "^1",
         "open-telemetry/symfony-sdk-bundle": "^0",
+        "psr/http-client": "^1.0",
+        "psr/http-factory": "^1.0",
         "symfony/config": "^7.4",
         "symfony/dependency-injection": "^7.4",
         "symfony/event-dispatcher": "^7.4",
@@ -85,7 +86,7 @@
         "open-telemetry/transport-grpc": "Needed to export OpenTelemetry data via gRPC",
         "symfony/cache": "Needed to enable Symfony Cache instrumentation",
         "symfony/console": "Needed to enable Symfony Console instrumentation",
-        "symfony/http-client": "Needed to enable Symfony HttpClient instrumentation",
+        "symfony/http-client": "Default PSR-18 HTTP client for telemetry export transports and needed to enable Symfony HttpClient instrumentation",
         "symfony/http-kernel": "Needed to enable Symfony HttpKernel instrumentation",
         "symfony/mailer": "Needed to enable Symfony Mailer instrumentation",
         "symfony/messenger": "Needed to enable Symfony Messenger instrumentation",

docs/src/user-guide/getting-started.md

@@ -31,10 +31,24 @@ To ensure a clean and optimal setup:
 
 #### HTTP PSR Discovery and `php-http/discovery`
 
-You may also be prompted to enable the `php-http/discovery` Composer plugin. This plugin allows libraries to discover HTTP PSR implementations dynamically. While this is required by many OpenTelemetry dependencies, our bundle relies directly on Guzzle HTTP for simplicity.
+You may also be prompted to enable the `php-http/discovery` Composer plugin. This plugin allows libraries to discover HTTP PSR implementations dynamically.
 
 - Recommendation: Enable the plugin if your application requires it, but this is optional.
-- If you believe relying directly on Guzzle HTTP is not ideal, please open an issue to share your feedback. As this package is in active development, we are open to exploring better solutions.
+
+#### HTTP client for telemetry export transports
+
+The bundle needs a PSR-18 HTTP client to export telemetry data over HTTP (OTLP, Zipkin). By default, it uses Symfony's `Psr18Client` if `symfony/http-client` is installed:
+
+```bash
+composer require symfony/http-client
+```
+
+You can use any PSR-18 compatible client by configuring the `transport_http_client` option:
+
+```yaml
+open_telemetry:
+  transport_http_client: app.my_custom_psr18_client
+```
 
 ### Supported Versions
 

src/DependencyInjection/Configuration.php

@@ -29,6 +29,15 @@ public function getConfigTreeBuilder(): TreeBuilder
 
         $rootNode = $treeBuilder->getRootNode();
 
+        $rootNode
+            ->children()
+                ->scalarNode('transport_http_client')
+                    ->info('Service ID used for telemetry export transports. Must implement PSR-18 ClientInterface and PSR-17 RequestFactoryInterface, StreamFactoryInterface. Defaults to Symfony Psr18Client.')
+                    ->defaultNull()
+                ->end()
+            ->end()
+        ;
+
         $this->addServiceSection($rootNode);
         $this->addInstrumentationSection($rootNode);
         $this->addTracesSection($rootNode);

src/DependencyInjection/OpenTelemetryExtension.php

@@ -11,6 +11,7 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
 use Symfony\Component\HttpClient\HttpClient;
+use Symfony\Component\HttpClient\Psr18Client;
 use Symfony\Component\HttpKernel\DependencyInjection\ConfigurableExtension;
 use Symfony\Component\Mailer\MailerInterface;
 use Symfony\Component\Messenger\Envelope;
@@ -52,6 +53,7 @@ protected function loadInternal(array $mergedConfig, ContainerBuilder $container
         $loader->load('services_tracing_instrumentation.php');
         $loader->load('services_metering_instrumentation.php');
 
+        $this->registerTransportHttpClient($mergedConfig['transport_http_client'], $container);
         $this->registerService($mergedConfig['service'], $container);
         $this->registerInstrumentation($mergedConfig['instrumentation'], $container);
 
@@ -84,6 +86,20 @@ private function registerService(array $config, ContainerBuilder $container): vo
             ]);
     }
 
+    private function registerTransportHttpClient(?string $httpClientServiceId, ContainerBuilder $container): void
+    {
+        if (null !== $httpClientServiceId) {
+            $container->setAlias('open_telemetry.transport_http_client', $httpClientServiceId);
+
+            return;
+        }
+
+        if (class_exists(Psr18Client::class)) {
+            $container->register('open_telemetry.transport_http_client.psr18', Psr18Client::class);
+            $container->setAlias('open_telemetry.transport_http_client', 'open_telemetry.transport_http_client.psr18');
+        }
+    }
+
     /**
      * @param array{
      *     cache: InstrumentationConfig,

src/Instrumentation/Symfony/HttpClient/TraceableHttpClient.php

@@ -2,12 +2,12 @@
 
 namespace FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\HttpClient;
 
-use GuzzleHttp\Psr7\Uri;
 use OpenTelemetry\API\Trace\SpanKind;
 use OpenTelemetry\API\Trace\TracerInterface;
 use OpenTelemetry\Context\Context;
 use OpenTelemetry\SemConv\Attributes\HttpAttributes;
 use OpenTelemetry\SemConv\Attributes\UrlAttributes;
+use Psr\Http\Message\UriFactoryInterface;
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\HttpClient\Response\ResponseStream;
@@ -21,6 +21,7 @@ final class TraceableHttpClient implements HttpClientInterface, LoggerAwareInter
     public function __construct(
         private HttpClientInterface $client,
         private readonly TracerInterface $tracer,
+        private readonly UriFactoryInterface $uriFactory,
         private ?LoggerInterface $logger = null,
     ) {
     }
@@ -37,7 +38,7 @@ public function request(string $method, string $url, array $options = []): Respo
             $this->logger?->debug('No active scope');
         }
 
-        $uri = new Uri($url);
+        $uri = $this->uriFactory->createUri($url);
 
         $spanBuilder = $this->tracer
             ->spanBuilder('http.client')

src/OpenTelemetry/Exporter/OtlpExporterEndpoint.php

@@ -3,7 +3,7 @@
 namespace FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter;
 
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Transport\TransportEnum;
-use GuzzleHttp\Psr7\HttpFactory;
+use Nyholm\Psr7\Factory\Psr17Factory;
 use OpenTelemetry\API\Signals;
 use OpenTelemetry\Contrib\Otlp\HttpEndpointResolverInterface;
 use OpenTelemetry\Contrib\Otlp\OtlpUtil;
@@ -26,7 +26,7 @@ private function __construct(
 
     public static function fromDsn(ExporterDsn $dsn): self
     {
-        return new self($dsn, new HttpFactory());
+        return new self($dsn, new Psr17Factory());
     }
 
     public function withSignal(string $signal): self

src/OpenTelemetry/Trace/ZipkinExporterEndpoint.php

@@ -6,7 +6,7 @@
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter\ExporterEndpointInterface;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Trace\SpanExporter\TraceExporterEnum;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Transport\TransportEnum;
-use GuzzleHttp\Psr7\HttpFactory;
+use Nyholm\Psr7\Factory\Psr17Factory;
 use Psr\Http\Message\UriFactoryInterface;
 
 final class ZipkinExporterEndpoint implements ExporterEndpointInterface
@@ -25,7 +25,7 @@ private function __construct(
 
     public static function fromDsn(ExporterDsn $dsn): self
     {
-        return new self($dsn, new HttpFactory());
+        return new self($dsn, new Psr17Factory());
     }
 
     public function __toString()

src/OpenTelemetry/Transport/OtlpHttpTransportFactory.php

@@ -6,14 +6,22 @@
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter\ExporterOptionsInterface;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter\OtlpExporterCompressionEnum;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter\OtlpExporterFormatEnum;
-use GuzzleHttp\Client;
-use GuzzleHttp\Psr7\HttpFactory;
 use OpenTelemetry\SDK\Common\Export\Http\PsrTransport;
 use OpenTelemetry\SDK\Common\Export\Http\PsrUtils;
 use OpenTelemetry\SDK\Common\Export\TransportInterface;
+use Psr\Http\Client\ClientInterface;
+use Psr\Http\Message\RequestFactoryInterface;
+use Psr\Http\Message\StreamFactoryInterface;
 
 final readonly class OtlpHttpTransportFactory implements TransportFactoryInterface
 {
+    public function __construct(
+        private ClientInterface $client,
+        private RequestFactoryInterface $requestFactory,
+        private StreamFactoryInterface $streamFactory,
+    ) {
+    }
+
     public function supports(#[\SensitiveParameter] ExporterEndpointInterface $endpoint, ExporterOptionsInterface $options): bool
     {
         if (null === $endpoint->getTransport()) {
@@ -34,9 +42,9 @@ public function createTransport(#[\SensitiveParameter] ExporterEndpointInterface
         $compression = OtlpExporterCompressionEnum::tryFrom($params->compression) ?? OtlpExporterCompressionEnum::None;
 
         return new PsrTransport(
-            new Client(),
-            new HttpFactory(),
-            new HttpFactory(),
+            $this->client,
+            $this->requestFactory,
+            $this->streamFactory,
             (string) $endpoint,
             $format,
             $params->headers,

src/OpenTelemetry/Transport/PsrHttpTransportFactory.php

@@ -6,14 +6,22 @@
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter\ExporterOptionsInterface;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter\OtlpExporterCompressionEnum;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter\OtlpExporterFormatEnum;
-use GuzzleHttp\Client;
-use GuzzleHttp\Psr7\HttpFactory;
 use OpenTelemetry\SDK\Common\Export\Http\PsrTransport;
 use OpenTelemetry\SDK\Common\Export\Http\PsrUtils;
 use OpenTelemetry\SDK\Common\Export\TransportInterface;
+use Psr\Http\Client\ClientInterface;
+use Psr\Http\Message\RequestFactoryInterface;
+use Psr\Http\Message\StreamFactoryInterface;
 
 final readonly class PsrHttpTransportFactory implements TransportFactoryInterface
 {
+    public function __construct(
+        private ClientInterface $client,
+        private RequestFactoryInterface $requestFactory,
+        private StreamFactoryInterface $streamFactory,
+    ) {
+    }
+
     public function supports(#[\SensitiveParameter] ExporterEndpointInterface $endpoint, ExporterOptionsInterface $options): bool
     {
         return null !== $endpoint->getTransport()
@@ -27,9 +35,9 @@ public function createTransport(#[\SensitiveParameter] ExporterEndpointInterface
         $compression = OtlpExporterCompressionEnum::tryFrom($params->compression) ?? OtlpExporterCompressionEnum::None;
 
         return new PsrTransport(
-            new Client(),
-            new HttpFactory(),
-            new HttpFactory(),
+            $this->client,
+            $this->requestFactory,
+            $this->streamFactory,
             (string) $endpoint,
             $format,
             $params->headers,

src/Resources/config/services_tracing_instrumentation.php

@@ -49,6 +49,7 @@
         // HTTP Client
         ->set('open_telemetry.instrumentation.http_client.trace.client', TraceableHttpClient::class)
             ->arg('$tracer', service('open_telemetry.traces.default_tracer'))
+            ->arg('$uriFactory', service('open_telemetry.transport_http_client'))
             ->tag('monolog.logger', ['channel' => 'open_telemetry'])
 
         // HTTP Kernel