Skip to content

Commit 7236edc

Browse files
committed
fix(messenger): namespace bus.name attribute as symfony.messenger.bus.name
bus.name is not a standard OTel semantic convention. Rename to symfony.messenger.bus.name to follow the existing codebase pattern (symfony.console.*, symfony.kernel.*). Only changes the worker subscriber attribute; the pre-existing bus.name in TraceableMessengerStack is left unchanged (out of scope).
1 parent 4a3da42 commit 7236edc

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/Instrumentation/Symfony/Messenger/WorkerMessageEventSubscriber.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public function startSpan(WorkerMessageReceivedEvent $event): void
7272
$busNameStamp = $event->getEnvelope()->last(BusNameStamp::class);
7373

7474
if (null !== $busNameStamp) {
75-
$span->setAttribute('bus.name', $busNameStamp->getBusName());
75+
$span->setAttribute('symfony.messenger.bus.name', $busNameStamp->getBusName());
7676
}
7777

7878
$this->logger->debug(sprintf('Starting span "%s"', $span->getContext()->getSpanId()));

tests/Functional/Instrumentation/Messenger/MessengerWorkerTracingTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function testWorkerMessageHandled(): void
4949
self::assertSpanAttributesSubSet($span, [
5050
'messaging.operation.type' => 'process',
5151
'messaging.destination.name' => 'main',
52-
'bus.name' => 'messenger.bus.default',
52+
'symfony.messenger.bus.name' => 'messenger.bus.default',
5353
]);
5454
self::assertSpanEventsCount($span, 0);
5555
}
@@ -89,7 +89,7 @@ public function testWorkerMessageFailed(): void
8989
self::assertSpanAttributesSubSet($span, [
9090
'messaging.operation.type' => 'process',
9191
'messaging.destination.name' => 'main',
92-
'bus.name' => 'messenger.bus.default',
92+
'symfony.messenger.bus.name' => 'messenger.bus.default',
9393
]);
9494
self::assertSpanEventsCount($span, 1);
9595

0 commit comments

Comments
 (0)